Tag smi-constants as smi. This also fixes code that copies holes into arrays.

Tag smi-constants as smi. This also fixes code that copies holes into arrays.

BUG=
R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=14814

[Toon Verwaest, 2013-05-24 17:15:15]

PTAL

[Jakob Kummerow, 2013-05-27 07:15:44]

LGTM with comments.

https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen-instru...
File src/hydrogen-instructions.h (right):

https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen-instru...
src/hydrogen-instructions.h:3402: // By default, binary instructions don't
handle Smis.
nit: s/instructions/operations/ for consistency in nomenclature.

https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen-instru...
src/hydrogen-instructions.h:3571: Representation r = Representation::None())
Since you're not using r any more, you can remove it entirely.

https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen.cc#new...
src/hydrogen.cc:1543: elements_kind = FAST_HOLEY_ELEMENTS;
nit: this looks a bit surprising, please add a comment, e.g.:
// Since we're about to store the hole value, the store instructions below
// must assume an elements kind that allows this.

[Toon Verwaest, 2013-05-27 08:43:54]

Addressed comments.

[Toon Verwaest, 2013-05-27 08:44:08]

Committed patchset #2 manually as r14814 (presubmit successful).