src/x64/lithium-codegen-x64.cc - Issue 15861009: Tag smi-constants as smi. This also fixes code that copies holes into arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 15861009: Tag smi-constants as smi. This also fixes code that copies holes into arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index c3db721319a05e7276dce8d09e857c6205f79048..dcfd7ab09cba8ad22e154591f87807b8fcc1ad91 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -431,7 +431,7 @@ XMMRegister LCodeGen::ToDoubleRegister(LOperand* op) const {

bool LCodeGen::IsInteger32Constant(LConstantOperand* op) const {

return op->IsConstantOperand() &&

- chunk_->LookupLiteralRepresentation(op).IsInteger32();

+ chunk_->LookupLiteralRepresentation(op).IsSmiOrInteger32();

}

« no previous file with comments | « src/property-details.h ('k') | no next file » | no next file with comments »