src/arm/lithium-codegen-arm.cc - Issue 15861009: Tag smi-constants as smi. This also fixes code that copies holes into arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 15861009: Tag smi-constants as smi. This also fixes code that copies holes into arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 07f733865f43b6c88a88f263d8534819732fe1ea..ebc6bb14f5e4fc8d81f66272f09823ed1904243d 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -524,7 +524,7 @@ Handle<Object> LCodeGen::ToHandle(LConstantOperand* op) const {

bool LCodeGen::IsInteger32(LConstantOperand* op) const {

- return chunk_->LookupLiteralRepresentation(op).IsInteger32();

+ return chunk_->LookupLiteralRepresentation(op).IsSmiOrInteger32();

}

« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »