Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 15821009: Move property setting/removing/addParsedProperty/addParsedProperties functions to MutableStylePrope… (Closed)

Created:
7 years, 7 months ago by darktears
Modified:
7 years, 7 months ago
Reviewers:
apavlov, eseidel
CC:
blink-reviews, kenneth.christiansen, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, darktears, pdr, f(malita), Stephen Chennney
Visibility:
Public.

Description

Move property setting/removing/addParsedProperty/addParsedProperties functions to MutableStylePropertySet. Move all functions for setting/removing properties from StylePropertySet to MutableStylePropertySet. Had to change SVGElement::animatedSMILStyleProperties() & friends to hand out MutableStylePropertySet* which was always the internal type anyway. Switch EditingStyle::m_mutableStyle to a RefPtr<MutableStylePropertySet>. This is a backport from WebKit r148400, r148402, 148403. Patches by Andreas Kling reviewed by Anders Carlsson and Antti Koivisto. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -107 lines) Patch
M Source/core/css/CSSParser.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 6 chunks +29 lines, -30 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 14 chunks +21 lines, -33 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/EditingStyle.h View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 13 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElementRareData.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darktears
There will be just one more and we're done with this refactor (I'll do it ...
7 years, 7 months ago (2013-05-24 20:49:17 UTC) #1
apavlov
lgtm
7 years, 7 months ago (2013-05-27 07:13:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15821009/1
7 years, 7 months ago (2013-05-27 11:22:37 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 11:25:24 UTC) #4
Message was sent while issue was closed.
Change committed as 151189

Powered by Google App Engine
This is Rietveld 408576698