Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: Source/core/css/StylePropertySet.h

Issue 15821009: Move property setting/removing/addParsedProperty/addParsedProperties functions to MutableStylePrope… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSParser.cpp ('k') | Source/core/css/StylePropertySet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/StylePropertySet.h
diff --git a/Source/core/css/StylePropertySet.h b/Source/core/css/StylePropertySet.h
index 553bca62ffcc3b8200fe1b608090429d5b83f4ba..78ac181b6bf850f1dcf7cfb8ce226cfba61a42af 100644
--- a/Source/core/css/StylePropertySet.h
+++ b/Source/core/css/StylePropertySet.h
@@ -105,27 +105,7 @@ public:
CSSPropertyID getPropertyShorthand(CSSPropertyID) const;
bool isPropertyImplicit(CSSPropertyID) const;
- // These expand shorthand properties into multiple properties.
- bool setProperty(CSSPropertyID, const String& value, bool important = false, StyleSheetContents* contextStyleSheet = 0);
- void setProperty(CSSPropertyID, PassRefPtr<CSSValue>, bool important = false);
-
- // These do not. FIXME: This is too messy, we can do better.
- bool setProperty(CSSPropertyID, int identifier, bool important = false);
- void appendPrefixingVariantProperty(const CSSProperty&);
- void setPrefixingVariantProperty(const CSSProperty&);
- void setProperty(const CSSProperty&, CSSProperty* slot = 0);
-
- bool removeProperty(CSSPropertyID, String* returnText = 0);
- void removePrefixedOrUnprefixedProperty(CSSPropertyID);
-
- void addParsedProperties(const Vector<CSSProperty>&);
- void addParsedProperty(const CSSProperty&);
-
- PassRefPtr<StylePropertySet> copyBlockProperties() const;
- void removeBlockProperties();
- bool removePropertiesInSet(const CSSPropertyID* set, unsigned length);
-
- void mergeAndOverrideOnConflict(const StylePropertySet*);
+ PassRefPtr<MutableStylePropertySet> copyBlockProperties() const;
CSSParserMode cssParserMode() const { return static_cast<CSSParserMode>(m_cssParserMode); }
@@ -134,9 +114,6 @@ public:
PassRefPtr<MutableStylePropertySet> mutableCopy() const;
PassRefPtr<ImmutableStylePropertySet> immutableCopyIfNeeded() const;
- void removeEquivalentProperties(const StylePropertySet*);
- void removeEquivalentProperties(const CSSStyleDeclaration*);
-
PassRefPtr<MutableStylePropertySet> copyPropertiesInSet(const Vector<CSSPropertyID>&) const;
String asText() const;
@@ -158,6 +135,8 @@ public:
const CSSValue** immutableValueArray() const;
const StylePropertyMetadata* immutableMetadataArray() const;
+ bool propertyMatches(CSSPropertyID, const CSSValue*) const;
+
protected:
StylePropertySet(CSSParserMode cssParserMode)
: m_cssParserMode(cssParserMode)
@@ -180,12 +159,6 @@ protected:
mutable unsigned m_ownsCSSOMWrapper : 1;
mutable unsigned m_isMutable : 1;
unsigned m_arraySize : 28;
-
-private:
- bool removeShorthandProperty(CSSPropertyID);
- bool propertyMatches(CSSPropertyID, const CSSValue*) const;
-
- CSSProperty* findMutableCSSPropertyWithID(CSSPropertyID);
friend class PropertySetCSSStyleDeclaration;
};
@@ -224,6 +197,28 @@ public:
MutableStylePropertySet(const StylePropertySet&);
+ void addParsedProperties(const Vector<CSSProperty>&);
+ void addParsedProperty(const CSSProperty&);
+
+ // These expand shorthand properties into multiple properties.
+ bool setProperty(CSSPropertyID, const String& value, bool important = false, StyleSheetContents* contextStyleSheet = 0);
+ void setProperty(CSSPropertyID, PassRefPtr<CSSValue>, bool important = false);
+
+ // These do not. FIXME: This is too messy, we can do better.
+ bool setProperty(CSSPropertyID, int identifier, bool important = false);
+ void appendPrefixingVariantProperty(const CSSProperty&);
+ void setPrefixingVariantProperty(const CSSProperty&);
+ void setProperty(const CSSProperty&, CSSProperty* slot = 0);
+
+ bool removeProperty(CSSPropertyID, String* returnText = 0);
+ void removePrefixedOrUnprefixedProperty(CSSPropertyID);
+ void removeBlockProperties();
+ bool removePropertiesInSet(const CSSPropertyID* set, unsigned length);
+ void removeEquivalentProperties(const StylePropertySet*);
+ void removeEquivalentProperties(const CSSStyleDeclaration*);
+
+ void mergeAndOverrideOnConflict(const StylePropertySet*);
+
void clear();
void parseDeclaration(const String& styleDeclaration, StyleSheetContents* contextStyleSheet);
@@ -236,7 +231,11 @@ private:
MutableStylePropertySet(CSSParserMode cssParserMode)
: StylePropertySet(cssParserMode)
{ }
+
MutableStylePropertySet(const CSSProperty* properties, unsigned count);
+
+ bool removeShorthandProperty(CSSPropertyID);
+ CSSProperty* findCSSPropertyWithID(CSSPropertyID);
};
inline Vector<CSSProperty, 4>& StylePropertySet::mutablePropertyVector()
« no previous file with comments | « Source/core/css/CSSParser.cpp ('k') | Source/core/css/StylePropertySet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698