Change the Lo-Fi snackbar strings for Lo-Fi preview pages

Change the Lo-Fi snackbar strings for Lo-Fi preview pages

The Lo-Fi snackbar should display the message "Slow connection" with the
action "LOAD ORIGINAL" when a q=preview response is received.

BUG=558632
Committed: https://crrev.com/03e2415f34093239e00424d1254ba9ea3fa4a89b
Cr-Commit-Position: refs/heads/master@{#368747}

[megjablon, 2016-01-08 20:08:49]

Patchset #1 (id:1) has been deleted

[megjablon, 2016-01-08 20:11:55]

megjablon@chromium.org changed reviewers:
+ newt@chromium.org, tbansal@chromium.org

[megjablon, 2016-01-08 20:11:55]

newt: chrome/*
tbansal: components/*

[tbansal1, 2016-01-08 20:52:31]

lgtm % nit.

https://chromiumcodereview.appspot.com/1576493002/diff/20001/components/data_...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
(right):

https://chromiumcodereview.appspot.com/1576493002/diff/20001/components/data_...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:120:
bool IsPreview() const { return is_preview_; }
s/IsPreview/is_preview/

[megjablon, 2016-01-08 20:54:19]

https://chromiumcodereview.appspot.com/1576493002/diff/20001/components/data_...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
(right):

https://chromiumcodereview.appspot.com/1576493002/diff/20001/components/data_...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:120:
bool IsPreview() const { return is_preview_; }
On 2016/01/08 20:52:31, tbansal1 wrote:
> s/IsPreview/is_preview/

Done.

[newt (away), 2016-01-11 21:52:25]

a few nits

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
(right):

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java:91:
mTab = tab;
I think this code would be easier to grasp if you created variables for the two
elements that vary -- the title and button text -- and deduplicate the shared
code, e.g.

    String message = mContext.getString(isPreview ? ...  : ...);
    String buttonText = ...
    mSnackbarManager.showSnackbar(
            Snackbar.make(message, this).setAction(buttonText, ...

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/android/j...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/android/j...
chrome/android/java/strings/android_chrome_strings.grd:725: <message
name="IDS_DATA_REDUCTION_LO_FI_PREVIEW_SNACKBAR_ACTION" desc="Button to load
images when page is opened in preview mode when there is a slow unreliable
connection.">
maybe a bit clearer: "Button to load original full-resolution images when..."

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/browser/a...
File chrome/browser/android/tab_android.h (right):

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/browser/a...
chrome/browser/android/tab_android.h:131: void OnLoFiResponseReceived(bool
is_preview);
please document this method. (all methods in .h files should be documented
except overrides and perhaps trivial getters/setters.)

In particular, as a reader, I would have no idea what "is_preview" means.

[megjablon, 2016-01-11 22:54:57]

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
(right):

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java:91:
mTab = tab;
On 2016/01/11 21:52:25, newt wrote:
> I think this code would be easier to grasp if you created variables for the
two
> elements that vary -- the title and button text -- and deduplicate the shared
> code, e.g.
> 
>     String message = mContext.getString(isPreview ? ...  : ...);
>     String buttonText = ...
>     mSnackbarManager.showSnackbar(
>             Snackbar.make(message, this).setAction(buttonText, ...

Done.

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/android/j...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/android/j...
chrome/android/java/strings/android_chrome_strings.grd:725: <message
name="IDS_DATA_REDUCTION_LO_FI_PREVIEW_SNACKBAR_ACTION" desc="Button to load
images when page is opened in preview mode when there is a slow unreliable
connection.">
On 2016/01/11 21:52:25, newt wrote:
> maybe a bit clearer: "Button to load original full-resolution images when..."

Done.

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/browser/a...
File chrome/browser/android/tab_android.h (right):

https://chromiumcodereview.appspot.com/1576493002/diff/40001/chrome/browser/a...
chrome/browser/android/tab_android.h:131: void OnLoFiResponseReceived(bool
is_preview);
On 2016/01/11 21:52:25, newt wrote:
> please document this method. (all methods in .h files should be documented
> except overrides and perhaps trivial getters/setters.)
> 
> In particular, as a reader, I would have no idea what "is_preview" means.

Done.

[newt (away), 2016-01-11 23:14:49]

lgtm thanks

[megjablon, 2016-01-11 23:26:09]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2016-01-11 23:26:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tbansal@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1576493002/#ps60001
(title: "newt comments")

[commit-bot: I haz the power, 2016-01-11 23:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576493002/60001

[commit-bot: I haz the power, 2016-01-12 01:08:56]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-12 01:10:24]

Description was changed from

==========
Change the Lo-Fi snackbar strings for Lo-Fi preview pages

The Lo-Fi snackbar should display the message "Slow connection" with the
action "LOAD ORIGINAL" when a q=preview response is received.

BUG=558632
==========

to

==========
Change the Lo-Fi snackbar strings for Lo-Fi preview pages

The Lo-Fi snackbar should display the message "Slow connection" with the
action "LOAD ORIGINAL" when a q=preview response is received.

BUG=558632

Committed: https://crrev.com/03e2415f34093239e00424d1254ba9ea3fa4a89b
Cr-Commit-Position: refs/heads/master@{#368747}
==========

[commit-bot: I haz the power, 2016-01-12 01:10:25]

Patchset 3 (id:??) landed as
https://crrev.com/03e2415f34093239e00424d1254ba9ea3fa4a89b
Cr-Commit-Position: refs/heads/master@{#368747}