Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

Issue 1576493002: Change the Lo-Fi snackbar strings for Lo-Fi preview pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@showLoFiSnackbarNative
Patch Set: newt comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
index 7b2c0035877ab2ac398231b49693eea2f3042672..77a828b58fdf536dabe9940b50ce9ba28d6f46c6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
@@ -54,15 +54,16 @@ public class LoFiBarPopupController implements SnackbarManager.SnackbarControlle
* snackbar.
*
* @param tab The tab to show the snackbar on.
+ * @param isPreview Whether the snackbar should have the Lo-Fi preview message.
*/
- public void maybeCreateLoFiBar(Tab tab) {
+ public void maybeCreateLoFiBar(Tab tab, final boolean isPreview) {
if (mLoFiPopupShownForPageLoad) return;
mLoFiPopupShownForPageLoad = true;
if (tab.isHidden()) {
TabObserver tabObserver = new EmptyTabObserver() {
@Override
public void onShown(Tab tab) {
- showLoFiBar(tab);
+ showLoFiBar(tab, isPreview);
tab.removeObserver(this);
}
@@ -79,19 +80,23 @@ public class LoFiBarPopupController implements SnackbarManager.SnackbarControlle
tab.addObserver(tabObserver);
return;
}
- showLoFiBar(tab);
+ showLoFiBar(tab, isPreview);
}
/**
* @param tab The tab. Saved to reload the page.
*/
- private void showLoFiBar(Tab tab) {
+ private void showLoFiBar(Tab tab, boolean isPreview) {
if (mDisabled) return;
mTab = tab;
- mSnackbarManager.showSnackbar(Snackbar.make(
- mContext.getString(R.string.data_reduction_lo_fi_snackbar_message), this)
- .setAction(mContext.getString(R.string.data_reduction_lo_fi_snackbar_action),
- tab.getId())
+ String message = mContext
+ .getString(isPreview ? R.string.data_reduction_lo_fi_preview_snackbar_message
+ : R.string.data_reduction_lo_fi_snackbar_message);
+ String buttonText = mContext
+ .getString(isPreview ? R.string.data_reduction_lo_fi_preview_snackbar_action
+ : R.string.data_reduction_lo_fi_snackbar_action);
+ mSnackbarManager.showSnackbar(Snackbar.make(message, this)
+ .setAction(buttonText, tab.getId())
.setDuration(DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS));
DataReductionProxySettings.getInstance().incrementLoFiSnackbarShown();
DataReductionProxyUma.dataReductionProxyLoFiUIAction(
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698