Lo-Fi snackbar should only be shown for the first q=low response of a page

Lo-Fi snackbar should only be shown for the first q=low response of a page.

When the DataReductionProxyNetworkDelegate sees a Lo-Fi response it notifies
Chrome. Chrome then gets the associated Android Tab and tells it to display
the Lo-Fi snackbar.

BUG=505483, 572974
Committed: https://crrev.com/8a15a7f2a109f8a6466d823fba4c4d635860d823
Cr-Commit-Position: refs/heads/master@{#368391}

[megjablon, 2015-12-30 02:47:37]

Description was changed from

==========
The Lo-Fi snackbar should only be shown for the first q=low response on a page

BUG=
==========

to

==========
Lo-Fi snackbar should only be shown for the first q=low response of a page

BUG=
==========

[megjablon, 2016-01-05 00:40:00]

Description was changed from

==========
Lo-Fi snackbar should only be shown for the first q=low response of a page

BUG=
==========

to

==========
Lo-Fi snackbar should only be shown for the first q=low response of a page.

BUG=505483, 572974
==========

[megjablon, 2016-01-05 00:42:03]

Patchset #1 (id:1) has been deleted

[megjablon, 2016-01-05 00:42:09]

Patchset #1 (id:20001) has been deleted

[megjablon, 2016-01-05 00:59:57]

Description was changed from

==========
Lo-Fi snackbar should only be shown for the first q=low response of a page.

BUG=505483, 572974
==========

to

==========
Lo-Fi snackbar should only be shown for the first q=low response of a page.

When the DataReductionProxyNetworkDelegate sees a Lo-Fi response it notifies 
Chrome. Chrome then gets the associated Android Tab and tells it to display 
the Lo-Fi snackbar.

BUG=505483, 572974
==========

[megjablon, 2016-01-05 01:00:34]

megjablon@chromium.org changed reviewers:
+ tbansal@chromium.org

[megjablon, 2016-01-05 01:00:34]

tbansal: components/*

[tbansal1, 2016-01-05 03:10:59]

Comments are on 2 different patch sets (mostly nits).

https://codereview.chromium.org/1558553002/diff/60001/chrome/browser/net/spdy...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
(right):

https://codereview.chromium.org/1558553002/diff/60001/chrome/browser/net/spdy...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc:45: if (tab)
{
braces not needed.

https://codereview.chromium.org/1558553002/diff/60001/components/data_reducti...
File components/data_reduction_proxy.gypi (right):

https://codereview.chromium.org/1558553002/diff/60001/components/data_reducti...
components/data_reduction_proxy.gypi:180: '../skia/skia.gyp:skia',
what is this for?

https://codereview.chromium.org/1558553002/diff/60001/components/data_reducti...
File components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc
(right):

https://codereview.chromium.org/1558553002/diff/60001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc:47:
DCHECK(!notify_lofi_response_received_callback_.is_null());
Can you add this DCHECK to the constructor also?

https://codereview.chromium.org/1558553002/diff/60001/components/data_reducti...
File components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
(right):

https://codereview.chromium.org/1558553002/diff/60001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:28: //
received. These notifications are used to show Lo-Fi UI in Android.
Please comment on whether this class is thread safe or not.

https://codereview.chromium.org/1558553002/diff/60001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:52:
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
add const qualifier to these two variables.

https://codereview.chromium.org/1558553002/diff/80001/chrome/browser/net/spdy...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
(right):

https://codereview.chromium.org/1558553002/diff/80001/chrome/browser/net/spdy...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc:42: void
NotifyLoFiResponseReceivedCallback(content::WebContents* web_contents) {
This function name matches the typdef in another file. Can we change this name
to something else?
May be simply NotifyLoFiResponseReceived?
Also, add comments.

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
File components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
(right):

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:28: //
received. These notifications are used to show Lo-Fi UI in Android.
s/These notifications are used to show Lo-Fi UI in Android./These notifications
may be used to show Lo-Fi UI./

because this class probably does not care about the OS-specific implementation?

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:32:
NotifyLoFiResponseReceivedCallback;
Does this typedef need to be public?

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:43:
void NotifyLoFiResponseReceivedOnUI(int render_process_id,
Does this need to be public?

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
File
components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc
(right):

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc:37:
DCHECK(ui_run_loop);
DCHECK not allowed in tests.

See https://www.chromium.org/developers/coding-style:
"Don't use these macros in tests, as they crash the test binary and leave bots
in a bad state.  Use the ASSERT_xx() and EXPECT_xx() family of macros..."

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
(right):

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h:182:
void set_lofi_ui_service(scoped_ptr<LoFiUIService> lofi_ui_service) const {
Can you comment on the ownership?

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
(right):

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:119:
bool DidNotifyLoFiResponse() { return notified_lofi_response_; }
Add const?

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:731:
raw_headers += "Chrome-Proxy: q=low\n";
Braces not needed.

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
File components/data_reduction_proxy/core/common/lofi_ui_service.h (right):

https://codereview.chromium.org/1558553002/diff/80001/components/data_reducti...
components/data_reduction_proxy/core/common/lofi_ui_service.h:24: const
net::URLRequest& request) const = 0;
It is somewhat confusing that this method is const since calling this method
actually changes the state in Tab.java (although through posting to a different
thread).

[megjablon, 2016-01-05 20:13:03]

https://chromiumcodereview.appspot.com/1558553002/diff/60001/chrome/browser/n...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/60001/chrome/browser/n...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc:45: if (tab)
{
On 2016/01/05 03:10:59, tbansal1 wrote:
> braces not needed.

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/60001/components/data_...
File components/data_reduction_proxy.gypi (right):

https://chromiumcodereview.appspot.com/1558553002/diff/60001/components/data_...
components/data_reduction_proxy.gypi:180: '../skia/skia.gyp:skia',
On 2016/01/05 03:10:59, tbansal1 wrote:
> what is this for?

Removed. This was for a content dependency that is no longer causing problems.

https://chromiumcodereview.appspot.com/1558553002/diff/60001/components/data_...
File components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/60001/components/data_...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc:47:
DCHECK(!notify_lofi_response_received_callback_.is_null());
On 2016/01/05 03:10:59, tbansal1 wrote:
> Can you add this DCHECK to the constructor also?

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/60001/components/data_...
File components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/60001/components/data_...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:28: //
received. These notifications are used to show Lo-Fi UI in Android.
On 2016/01/05 03:10:59, tbansal1 wrote:
> Please comment on whether this class is thread safe or not.

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/60001/components/data_...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:52:
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
On 2016/01/05 03:10:59, tbansal1 wrote:
> add const qualifier to these two variables.

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/80001/chrome/browser/n...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/80001/chrome/browser/n...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc:42: void
NotifyLoFiResponseReceivedCallback(content::WebContents* web_contents) {
On 2016/01/05 03:10:59, tbansal1 wrote:
> This function name matches the typdef in another file. Can we change this name
> to something else?
> May be simply NotifyLoFiResponseReceived?
> Also, add comments.

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
File components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:28: //
received. These notifications are used to show Lo-Fi UI in Android.
On 2016/01/05 03:10:59, tbansal1 wrote:
> s/These notifications are used to show Lo-Fi UI in Android./These
notifications
> may be used to show Lo-Fi UI./
> 
> because this class probably does not care about the OS-specific
implementation?

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:32:
NotifyLoFiResponseReceivedCallback;
On 2016/01/05 03:10:59, tbansal1 wrote:
> Does this typedef need to be public?

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.h:43:
void NotifyLoFiResponseReceivedOnUI(int render_process_id,
On 2016/01/05 03:10:59, tbansal1 wrote:
> Does this need to be public?

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
File
components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc:37:
DCHECK(ui_run_loop);
On 2016/01/05 03:10:59, tbansal1 wrote:
> DCHECK not allowed in tests.
> 
> See https://www.chromium.org/developers/coding-style:
> "Don't use these macros in tests, as they crash the test binary and leave bots
> in a bad state.  Use the ASSERT_xx() and EXPECT_xx() family of macros..."

Done and good to know. We do this in other parts of our code.

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h:182:
void set_lofi_ui_service(scoped_ptr<LoFiUIService> lofi_ui_service) const {
On 2016/01/05 03:10:59, tbansal1 wrote:
> Can you comment on the ownership?

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:119:
bool DidNotifyLoFiResponse() { return notified_lofi_response_; }
On 2016/01/05 03:10:59, tbansal1 wrote:
> Add const?

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:731:
raw_headers += "Chrome-Proxy: q=low\n";
On 2016/01/05 03:10:59, tbansal1 wrote:
> Braces not needed.

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
File components/data_reduction_proxy/core/common/lofi_ui_service.h (right):

https://chromiumcodereview.appspot.com/1558553002/diff/80001/components/data_...
components/data_reduction_proxy/core/common/lofi_ui_service.h:24: const
net::URLRequest& request) const = 0;
On 2016/01/05 03:10:59, tbansal1 wrote:
> It is somewhat confusing that this method is const since calling this method
> actually changes the state in Tab.java (although through posting to a
different
> thread).

Done.

[tbansal1, 2016-01-05 21:07:09]

https://codereview.chromium.org/1558553002/diff/100001/chrome/android/java/sr...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1558553002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:463:
public void showLoFiPopup(Tab tab) {
Please add javadocs comments for the function.

https://codereview.chromium.org/1558553002/diff/100001/chrome/browser/net/spd...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
(right):

https://codereview.chromium.org/1558553002/diff/100001/chrome/browser/net/spd...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc:43: //
Notifies the TabAndroid associated with |web_contents| that a Lo-Fi response
Rewrite the comment so that it is clear that this function does X for OS_ANDROID
and nothing for other platforms.

https://codereview.chromium.org/1558553002/diff/100001/components/data_reduct...
File components/data_reduction_proxy.gypi (right):

https://codereview.chromium.org/1558553002/diff/100001/components/data_reduct...
components/data_reduction_proxy.gypi:179: '../skia/skia.gyp:skia',
Is this dependency needed?

https://codereview.chromium.org/1558553002/diff/100001/components/data_reduct...
File components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc
(right):

https://codereview.chromium.org/1558553002/diff/100001/components/data_reduct...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc:30:
const net::URLRequest& request) {
Add DCHECK that this is currently on IO thread?

https://codereview.chromium.org/1558553002/diff/100001/components/data_reduct...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc:45:
content::RenderFrameHost* frame =
nit: const

[megjablon, 2016-01-05 23:06:55]

Patchset #5 (id:120001) has been deleted

[megjablon, 2016-01-06 17:20:47]

https://chromiumcodereview.appspot.com/1558553002/diff/100001/chrome/android/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/100001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:463:
public void showLoFiPopup(Tab tab) {
On 2016/01/05 21:07:09, tbansal1 wrote:
> Please add javadocs comments for the function.

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/100001/chrome/browser/...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/100001/chrome/browser/...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc:43: //
Notifies the TabAndroid associated with |web_contents| that a Lo-Fi response
On 2016/01/05 21:07:09, tbansal1 wrote:
> Rewrite the comment so that it is clear that this function does X for
OS_ANDROID
> and nothing for other platforms.

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/100001/components/data...
File components/data_reduction_proxy.gypi (right):

https://chromiumcodereview.appspot.com/1558553002/diff/100001/components/data...
components/data_reduction_proxy.gypi:179: '../skia/skia.gyp:skia',
On 2016/01/05 21:07:09, tbansal1 wrote:
> Is this dependency needed?

It's needed for the WebContents include:

"FAILED:
In file included from
../../components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc:13:
In file included from ../../content/public/browser/web_contents.h:26:
In file included from ../../third_party/skia/include/core/SkColor.h:11:
In file included from ../../third_party/skia/include/core/SkScalar.h:12:
../../third_party/skia/include/core/../private/SkFloatingPoint.h:13:10: fatal
error: 'SkTypes.h' file not found
#include "SkTypes.h"
         ^
1 error generated.
ninja: build stopped: subcommand failed."

https://chromiumcodereview.appspot.com/1558553002/diff/100001/components/data...
File components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/100001/components/data...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc:30:
const net::URLRequest& request) {
On 2016/01/05 21:07:09, tbansal1 wrote:
> Add DCHECK that this is currently on IO thread?

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/100001/components/data...
components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc:45:
content::RenderFrameHost* frame =
On 2016/01/05 21:07:09, tbansal1 wrote:
> nit: const

FromRenderFrameHost takes as non-const pointer so this can't be const

[megjablon, 2016-01-06 17:21:18]

megjablon@chromium.org changed reviewers:
+ newt@chromium.org

[megjablon, 2016-01-06 17:21:19]

newt: chrome/* android related files

[tbansal1, 2016-01-06 17:29:18]

lgtm

[newt (away), 2016-01-06 19:03:27]

https://chromiumcodereview.appspot.com/1558553002/diff/140001/chrome/android/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/140001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:468:
public void showLoFiPopup(Tab tab) {
All the lo-fi snackbar logic should be moved into Tab.java, or even better into
LoFiBarPopupController.java.

ChromeActivity shouldn't be meddling in Tab-level affairs, and moreover, Tab
should have as little knowledge as possible (ideally none) of ChromeActivity.

https://chromiumcodereview.appspot.com/1558553002/diff/140001/chrome/browser/...
File chrome/browser/android/tab_android.cc (right):

https://chromiumcodereview.appspot.com/1558553002/diff/140001/chrome/browser/...
chrome/browser/android/tab_android.cc:828: void
TabAndroid::NotifyLoFiResponseReceived() {
how about calling this "OnLoFi...", which is the more common naming pattern for
this type of method.

[megjablon, 2016-01-07 21:22:00]

Patchset #6 (id:160001) has been deleted

[megjablon, 2016-01-07 21:22:05]

https://chromiumcodereview.appspot.com/1558553002/diff/140001/chrome/android/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://chromiumcodereview.appspot.com/1558553002/diff/140001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:468:
public void showLoFiPopup(Tab tab) {
On 2016/01/06 19:03:27, newt wrote:
> All the lo-fi snackbar logic should be moved into Tab.java, or even better
into
> LoFiBarPopupController.java.
> 
> ChromeActivity shouldn't be meddling in Tab-level affairs, and moreover, Tab
> should have as little knowledge as possible (ideally none) of ChromeActivity.

Done.

https://chromiumcodereview.appspot.com/1558553002/diff/140001/chrome/browser/...
File chrome/browser/android/tab_android.cc (right):

https://chromiumcodereview.appspot.com/1558553002/diff/140001/chrome/browser/...
chrome/browser/android/tab_android.cc:828: void
TabAndroid::NotifyLoFiResponseReceived() {
On 2016/01/06 19:03:27, newt wrote:
> how about calling this "OnLoFi...", which is the more common naming pattern
for
> this type of method.

Done.

[newt (away), 2016-01-07 21:35:07]

Thanks for the cleanup :)

lgtm

[megjablon, 2016-01-07 21:36:13]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2016-01-07 21:36:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tbansal@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1558553002/#ps180001 (title: "newt
comments")

[commit-bot: I haz the power, 2016-01-07 21:36:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558553002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558553002/180001

[commit-bot: I haz the power, 2016-01-07 23:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-07 23:52:44]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[megjablon, 2016-01-08 17:54:04]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2016-01-08 17:54:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
tbansal@chromium.org, newt@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1558553002/#ps200001 (title: "test fix")

[megjablon, 2016-01-08 17:54:40]

The CQ bit was unchecked by megjablon@chromium.org

[megjablon, 2016-01-08 17:58:48]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2016-01-08 17:58:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
tbansal@chromium.org, newt@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1558553002/#ps220001 (title: "test fix")

[commit-bot: I haz the power, 2016-01-08 17:59:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558553002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558553002/220001

[commit-bot: I haz the power, 2016-01-08 19:05:36]

Description was changed from

==========
Lo-Fi snackbar should only be shown for the first q=low response of a page.

When the DataReductionProxyNetworkDelegate sees a Lo-Fi response it notifies 
Chrome. Chrome then gets the associated Android Tab and tells it to display 
the Lo-Fi snackbar.

BUG=505483, 572974
==========

to

==========
Lo-Fi snackbar should only be shown for the first q=low response of a page.

When the DataReductionProxyNetworkDelegate sees a Lo-Fi response it notifies 
Chrome. Chrome then gets the associated Android Tab and tells it to display 
the Lo-Fi snackbar.

BUG=505483, 572974
==========

[commit-bot: I haz the power, 2016-01-08 19:05:36]

Committed patchset #8 (id:220001)

[commit-bot: I haz the power, 2016-01-08 19:07:33]

Description was changed from

==========
Lo-Fi snackbar should only be shown for the first q=low response of a page.

When the DataReductionProxyNetworkDelegate sees a Lo-Fi response it notifies 
Chrome. Chrome then gets the associated Android Tab and tells it to display 
the Lo-Fi snackbar.

BUG=505483, 572974
==========

to

==========
Lo-Fi snackbar should only be shown for the first q=low response of a page.

When the DataReductionProxyNetworkDelegate sees a Lo-Fi response it notifies
Chrome. Chrome then gets the associated Android Tab and tells it to display
the Lo-Fi snackbar.

BUG=505483, 572974

Committed: https://crrev.com/8a15a7f2a109f8a6466d823fba4c4d635860d823
Cr-Commit-Position: refs/heads/master@{#368391}
==========

[commit-bot: I haz the power, 2016-01-08 19:07:33]

Patchset 8 (id:??) landed as
https://crrev.com/8a15a7f2a109f8a6466d823fba4c4d635860d823
Cr-Commit-Position: refs/heads/master@{#368391}

[megjablon, 2016-03-16 01:22:09]

Patchset #7 (id:200001) has been deleted