Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc

Issue 1558553002: Lo-Fi snackbar should only be shown for the first q=low response of a page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc
diff --git a/components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc b/components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3ed2f3c449d3f790b56a2e99576044456acc3c08
--- /dev/null
+++ b/components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc
@@ -0,0 +1,111 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/data_reduction_proxy/content/browser/content_lofi_ui_service.h"
+
+#include <stddef.h>
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/resource_request_info.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/test_renderer_host.h"
+#include "net/socket/socket_test_util.h"
+#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace data_reduction_proxy {
+
+class ContentLoFiUIServiceTest : public content::RenderViewHostTestHarness {
+ public:
+ ContentLoFiUIServiceTest() : callback_called_(false) {
+ // Cannot use IO_MAIN_LOOP with RenderViewHostTestHarness.
+ SetThreadBundleOptions(content::TestBrowserThreadBundle::REAL_IO_THREAD);
+ }
+
+ void RunTestOnIOThread(base::RunLoop* ui_run_loop) {
+ ASSERT_TRUE(ui_run_loop);
+ EXPECT_TRUE(
+ content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+
+ net::TestURLRequestContext context(true);
+ net::MockClientSocketFactory mock_socket_factory;
+ net::TestDelegate delegate;
+ context.set_client_socket_factory(&mock_socket_factory);
+ context.Init();
+
+ content_lofi_ui_service_.reset(new ContentLoFiUIService(
+ content::BrowserThread::GetMessageLoopProxyForThread(
+ content::BrowserThread::UI),
+ base::Bind(&ContentLoFiUIServiceTest::OnLoFiResponseReceivedCallback,
+ base::Unretained(this))));
+
+ scoped_ptr<net::URLRequest> request = CreateRequest(context, &delegate);
+
+ content_lofi_ui_service_->OnLoFiReponseReceived(*request);
+
+ content::BrowserThread::PostTask(
+ content::BrowserThread::UI, FROM_HERE,
+ base::Bind(&base::RunLoop::Quit, base::Unretained(ui_run_loop)));
+ }
+
+ scoped_ptr<net::URLRequest> CreateRequest(
+ const net::TestURLRequestContext& context,
+ net::TestDelegate* delegate) {
+ EXPECT_TRUE(
+ content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+
+ scoped_ptr<net::URLRequest> request = context.CreateRequest(
+ GURL("http://www.google.com/"), net::IDLE, delegate);
+
+ content::ResourceRequestInfo::AllocateForTesting(
+ request.get(), content::RESOURCE_TYPE_SUB_FRAME, NULL,
+ web_contents()->GetMainFrame()->GetProcess()->GetID(), -1,
+ web_contents()->GetMainFrame()->GetRoutingID(),
+ false, // is_main_frame
+ false, // parent_is_main_frame
+ false, // allow_download
+ false, // is_async
+ true); // is_using_lofi
+
+ return request;
+ }
+
+ void OnLoFiResponseReceivedCallback(content::WebContents* web_contents) {
+ EXPECT_TRUE(
+ content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ callback_called_ = true;
+ }
+
+ void VerifyOnLoFiResponseReceivedCallback() {
+ EXPECT_TRUE(
+ content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ EXPECT_TRUE(callback_called_);
+ }
+
+ private:
+ scoped_ptr<ContentLoFiUIService> content_lofi_ui_service_;
+ bool callback_called_;
+};
+
+TEST_F(ContentLoFiUIServiceTest, OnLoFiResponseReceived) {
+ base::RunLoop ui_run_loop;
+ content::BrowserThread::PostTask(
+ content::BrowserThread::IO, FROM_HERE,
+ base::Bind(&ContentLoFiUIServiceTest::RunTestOnIOThread,
+ base::Unretained(this), &ui_run_loop));
+ ui_run_loop.Run();
+ base::MessageLoop::current()->RunUntilIdle();
+ VerifyOnLoFiResponseReceivedCallback();
+}
+
+} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698