Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Unified Diff: net/spdy/spdy_session.cc

Issue 1545403002: Return false when trusted SPDY proxy advertises HTTPS URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ps Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index a2fec98d21edd9a6411975b372c9a9aad7e7fb9c..d24ed404c01b044e04206fd9384ea2edbabbabd0 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -2731,6 +2731,7 @@ bool SpdySession::TryCreatePushStream(SpdyStreamId stream_id,
RST_STREAM_REFUSED_STREAM,
base::StringPrintf("Rejected push of Cross Origin HTTPS content %d",
associated_stream_id));
+ return false;
bengr 2015/12/29 18:02:33 Please explain this in much more detail. Update th
tbansal1 2015/12/30 00:00:52 Added CL description. This function is expected to
}
} else {
GURL associated_url(associated_it->second.stream->GetUrlFromHeaders());

Powered by Google App Engine
This is Rietveld 408576698