Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1545403002:
Return false when trusted SPDY proxy advertises HTTPS URL (Closed)
DescriptionReturn false when trusted SPDY proxy advertises HTTPS URL.
Adds a missing return statement so that
SpdySession::TryCreatePushStream returns false when a cross-
origin push by a trusted SPDY proxy advertises an HTTPS URL.
Also, add tests that verify the correctness of trusted SPDY
proxy.
BUG=572766, 572767
Committed: https://crrev.com/fa4a762f62a3f22c0df12b698c43ea413ec4ebfb
Cr-Commit-Position: refs/heads/master@{#368973}
Patch Set 1 : #Patch Set 2 : ps #
Total comments: 10
Patch Set 3 : Addressed bengr comments #
Total comments: 24
Patch Set 4 : Addressed comments #
Total comments: 5
Patch Set 5 : Addressed bengr comments #
Total comments: 2
Patch Set 6 : Addressed bengr comment #
Total comments: 4
Patch Set 7 : Addressed comments #Messages
Total messages: 33 (15 generated)
Description was changed from ========== w w w passing passing BUG= ========== to ========== Return false when trusted SPDY proxy pushes HTTPS resources. Also, add some tests for trusted SPDY proxy. BUG=572766, 572767 ==========
Patchset #1 (id:1) has been deleted
tbansal@chromium.org changed reviewers: + bengr@chromium.org
bengr: PTAL. Thanks.
https://codereview.chromium.org/1545403002/diff/40001/net/spdy/spdy_session.cc File net/spdy/spdy_session.cc (right): https://codereview.chromium.org/1545403002/diff/40001/net/spdy/spdy_session.c... net/spdy/spdy_session.cc:2734: return false; Please explain this in much more detail. Update the CL description, please. https://codereview.chromium.org/1545403002/diff/40001/net/spdy/spdy_session.h File net/spdy/spdy_session.h (right): https://codereview.chromium.org/1545403002/diff/40001/net/spdy/spdy_session.h... net/spdy/spdy_session.h:967: void set_trusted_spdy_proxy_for_tests(const HostPortPair& host_port_pair) { This shouldn't be necessary. See my comment in your tests. https://codereview.chromium.org/1545403002/diff/40001/net/spdy/spdy_session_u... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/40001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4845: // Tests that only the HTTP SPDY push requests from trusted SPDY proxies are Shouldn't SPDY push work for same origin pushes even if the SPDY proxy is not explicitly trusted? https://codereview.chromium.org/1545403002/diff/40001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4875: CreateNetworkSession(); You should be able to pass in the trusted SPDY proxy via SPDYSessionDependencies when you create the NetworkSession. https://codereview.chromium.org/1545403002/diff/40001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4929: // Tests that if the SPDY trusted proxy is not set, than push requests for a Test that a push from the same origin should succeed.
Description was changed from ========== Return false when trusted SPDY proxy pushes HTTPS resources. Also, add some tests for trusted SPDY proxy. BUG=572766, 572767 ========== to ========== Return false when trusted SPDY proxy pushes HTTPS resources. TryCreatePushStream() should return false when the push stream is not created. Also, add some tests for trusted SPDY proxy. BUG=572766, 572767 ==========
Patchset #3 (id:60001) has been deleted
bengr: ptal. thanks. https://chromiumcodereview.appspot.com/1545403002/diff/40001/net/spdy/spdy_se... File net/spdy/spdy_session.cc (right): https://chromiumcodereview.appspot.com/1545403002/diff/40001/net/spdy/spdy_se... net/spdy/spdy_session.cc:2734: return false; On 2015/12/29 18:02:33, bengr wrote: > Please explain this in much more detail. Update the CL description, please. Added CL description. This function is expected to return false when the push stream is not created. https://chromiumcodereview.appspot.com/1545403002/diff/40001/net/spdy/spdy_se... File net/spdy/spdy_session.h (right): https://chromiumcodereview.appspot.com/1545403002/diff/40001/net/spdy/spdy_se... net/spdy/spdy_session.h:967: void set_trusted_spdy_proxy_for_tests(const HostPortPair& host_port_pair) { On 2015/12/29 18:02:33, bengr wrote: > This shouldn't be necessary. See my comment in your tests. Done. https://chromiumcodereview.appspot.com/1545403002/diff/40001/net/spdy/spdy_se... File net/spdy/spdy_session_unittest.cc (right): https://chromiumcodereview.appspot.com/1545403002/diff/40001/net/spdy/spdy_se... net/spdy/spdy_session_unittest.cc:4845: // Tests that only the HTTP SPDY push requests from trusted SPDY proxies are On 2015/12/29 18:02:33, bengr wrote: > Shouldn't SPDY push work for same origin pushes even if the SPDY proxy is not > explicitly trusted? Fixed the comment. https://chromiumcodereview.appspot.com/1545403002/diff/40001/net/spdy/spdy_se... net/spdy/spdy_session_unittest.cc:4875: CreateNetworkSession(); On 2015/12/29 18:02:33, bengr wrote: > You should be able to pass in the trusted SPDY proxy via SPDYSessionDependencies > when you create the NetworkSession. Done. https://chromiumcodereview.appspot.com/1545403002/diff/40001/net/spdy/spdy_se... net/spdy/spdy_session_unittest.cc:4929: // Tests that if the SPDY trusted proxy is not set, than push requests for a On 2015/12/29 18:02:33, bengr wrote: > Test that a push from the same origin should succeed. That's already checked in another existing test: RejectPushedStreamExceedingConcurrencyLimit.
Change the CL desription to say: Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross-origin push by a trusted SPDY proxy advertises an HTTPS URL. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4845: // Tests that HTTP SPDY push streams that advertise a different origin than the a different origin than -> an origin different from trusted SPDY proxies -> a trusted SPDY proxy https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4851: // push_a pushes resources for example2.org which is different from I'd rename the variables cross_origin_push and cross_origin_https_push. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4854: nullptr, 0, 2, 1, "http://www.example2.org/a.dat")); I'd create another constant called kAnotherURL. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4864: scoped_ptr<SpdyFrame> req( Call this "request" and the latter one "reset" https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4874: session_deps_.trusted_spdy_proxy = "www.example.org:80"; Shouldn't this be HostPortPair::FromURL(GURL(kDefaultURL)).ToString()? https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4879: base::WeakPtr<SpdyStream> spdy_stream1 = CreateStreamSynchronously( Can you just call this spdy_stream? https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4883: test::StreamDelegateDoNothing delegate1(spdy_stream1); delegate1 -> delegate https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4927: // Tests that if the SPDY trusted proxy is not set, than push streams that than -> then a different origin than -> an origin different from For the latter, fix everywhere. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4931: ASSERT_TRUE(std::string(kDefaultURL).find("example2.org") == Better to use GURL(kDefaultURL).GetOrigin(). https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4933: // push_a contains resource for a origin different than kDefaultURL, and Call push_a cross_origin_push. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4956: base::WeakPtr<SpdyStream> spdy_stream1 = CreateStreamSynchronously( Rename as spdy_stream. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4961: spdy_stream1->SetDelegate(&delegate1); delegate1 -> delegate
On 2016/01/05 21:01:37, bengr wrote: > Change the CL desription to say: > > Adds a missing return statement so that SpdySession::TryCreatePushStream returns > false when a cross-origin push by a trusted SPDY proxy advertises an HTTPS URL. > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > File net/spdy/spdy_session_unittest.cc (right): > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4845: // Tests that HTTP SPDY push streams > that advertise a different origin than the > a different origin than -> an origin different from > trusted SPDY proxies -> a trusted SPDY proxy > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4851: // push_a pushes resources for > http://example2.org which is different from > I'd rename the variables cross_origin_push and cross_origin_https_push. > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4854: nullptr, 0, 2, 1, > "http://www.example2.org/a.dat")); > I'd create another constant called kAnotherURL. > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4864: scoped_ptr<SpdyFrame> req( > Call this "request" and the latter one "reset" > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4874: session_deps_.trusted_spdy_proxy = > "www.example.org:80"; > Shouldn't this be HostPortPair::FromURL(GURL(kDefaultURL)).ToString()? > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4879: base::WeakPtr<SpdyStream> spdy_stream1 = > CreateStreamSynchronously( > Can you just call this spdy_stream? > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4883: test::StreamDelegateDoNothing > delegate1(spdy_stream1); > delegate1 -> delegate > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4927: // Tests that if the SPDY trusted proxy > is not set, than push streams that > than -> then > a different origin than -> an origin different from > > For the latter, fix everywhere. > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4931: > ASSERT_TRUE(std::string(kDefaultURL).find("example2.org") == > Better to use GURL(kDefaultURL).GetOrigin(). > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4933: // push_a contains resource for a origin > different than kDefaultURL, and > Call push_a cross_origin_push. > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4956: base::WeakPtr<SpdyStream> spdy_stream1 = > CreateStreamSynchronously( > Rename as spdy_stream. > > https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... > net/spdy/spdy_session_unittest.cc:4961: spdy_stream1->SetDelegate(&delegate1); > delegate1 -> delegate Also, only refer to the bug that states that the return is missing. The other bug should block on that one.
Description was changed from ========== Return false when trusted SPDY proxy pushes HTTPS resources. TryCreatePushStream() should return false when the push stream is not created. Also, add some tests for trusted SPDY proxy. BUG=572766, 572767 ========== to ========== Return false when trusted SPDY proxy advertises HTTPS URL. Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross- origin push by a trusted SPDY proxy advertises an HTTPS URL. BUG=572766, 572767 ==========
Description was changed from ========== Return false when trusted SPDY proxy advertises HTTPS URL. Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross- origin push by a trusted SPDY proxy advertises an HTTPS URL. BUG=572766, 572767 ========== to ========== Return false when trusted SPDY proxy advertises HTTPS URL. Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross- origin push by a trusted SPDY proxy advertises an HTTPS URL. Also, add some tests that verify the functionality of trusted SPDY proxy. BUG=572766, 572767 ==========
Description was changed from ========== Return false when trusted SPDY proxy advertises HTTPS URL. Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross- origin push by a trusted SPDY proxy advertises an HTTPS URL. Also, add some tests that verify the functionality of trusted SPDY proxy. BUG=572766, 572767 ========== to ========== Return false when trusted SPDY proxy advertises HTTPS URL. Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross- origin push by a trusted SPDY proxy advertises an HTTPS URL. Also, add tests that verify the correctness of trusted SPDY proxy. BUG=572766, 572767 ==========
bengr: PTAL. Thanks. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4845: // Tests that HTTP SPDY push streams that advertise a different origin than the On 2016/01/05 21:01:37, bengr wrote: > a different origin than -> an origin different from > trusted SPDY proxies -> a trusted SPDY proxy Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4851: // push_a pushes resources for example2.org which is different from On 2016/01/05 21:01:37, bengr wrote: > I'd rename the variables cross_origin_push and cross_origin_https_push. Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4854: nullptr, 0, 2, 1, "http://www.example2.org/a.dat")); On 2016/01/05 21:01:37, bengr wrote: > I'd create another constant called kAnotherURL. Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4864: scoped_ptr<SpdyFrame> req( On 2016/01/05 21:01:37, bengr wrote: > Call this "request" and the latter one "reset" Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4874: session_deps_.trusted_spdy_proxy = "www.example.org:80"; On 2016/01/05 21:01:37, bengr wrote: > Shouldn't this be HostPortPair::FromURL(GURL(kDefaultURL)).ToString()? Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4879: base::WeakPtr<SpdyStream> spdy_stream1 = CreateStreamSynchronously( On 2016/01/05 21:01:37, bengr wrote: > Can you just call this spdy_stream? Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4883: test::StreamDelegateDoNothing delegate1(spdy_stream1); On 2016/01/05 21:01:37, bengr wrote: > delegate1 -> delegate Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4927: // Tests that if the SPDY trusted proxy is not set, than push streams that On 2016/01/05 21:01:37, bengr wrote: > than -> then > a different origin than -> an origin different from > > For the latter, fix everywhere. Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4931: ASSERT_TRUE(std::string(kDefaultURL).find("example2.org") == On 2016/01/05 21:01:37, bengr wrote: > Better to use GURL(kDefaultURL).GetOrigin(). Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4933: // push_a contains resource for a origin different than kDefaultURL, and On 2016/01/05 21:01:37, bengr wrote: > Call push_a cross_origin_push. Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4956: base::WeakPtr<SpdyStream> spdy_stream1 = CreateStreamSynchronously( On 2016/01/05 21:01:37, bengr wrote: > Rename as spdy_stream. Done. https://codereview.chromium.org/1545403002/diff/80001/net/spdy/spdy_session_u... net/spdy/spdy_session_unittest.cc:4961: spdy_stream1->SetDelegate(&delegate1); On 2016/01/05 21:01:37, bengr wrote: > delegate1 -> delegate Done.
https://codereview.chromium.org/1545403002/diff/100001/net/spdy/spdy_session_... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/100001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4852: // Push resources for kAnotherURL which is different from kDefaultURL. This doesn't make sense. Maybe call kAnotherURL kAnotherOrigin if you are going to use constants. https://codereview.chromium.org/1545403002/diff/100001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4856: nullptr, 0, 2, 1, ("http://www." + kAnotherURL + "/a.dat").c_str())); My earlier comment was mainly about the example1 URL and these example2 URLs being defined in different places. It might be cleanest to use string literals for all URLs and hosts in these tests, instead of string constants that are defined all over the place.
https://codereview.chromium.org/1545403002/diff/100001/net/spdy/spdy_session_... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/100001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4856: nullptr, 0, 2, 1, ("http://www." + kAnotherURL + "/a.dat").c_str())); On 2016/01/08 18:57:27, bengr wrote: > My earlier comment was mainly about the example1 URL and these example2 URLs > being defined in different places. It might be cleanest to use string literals > for all URLs and hosts in these tests, instead of string constants that are > defined all over the place. Actually, if kDefaultURL is required by the test harness, I'd just add: const char[] kHttpURLFromAnotherOrigin = "http://www.example2.com/a.dat"; const char[] kHttpsURLFromAnotherOrigin = ... and extract the origin from one of these as needed.
bengr: PTAL. Thanks. https://codereview.chromium.org/1545403002/diff/100001/net/spdy/spdy_session_... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/100001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4852: // Push resources for kAnotherURL which is different from kDefaultURL. On 2016/01/08 18:57:27, bengr wrote: > This doesn't make sense. Maybe call kAnotherURL kAnotherOrigin if you are going > to use constants. Done. https://codereview.chromium.org/1545403002/diff/100001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4856: nullptr, 0, 2, 1, ("http://www." + kAnotherURL + "/a.dat").c_str())); On 2016/01/08 19:06:35, bengr wrote: > On 2016/01/08 18:57:27, bengr wrote: > > My earlier comment was mainly about the example1 URL and these example2 URLs > > being defined in different places. It might be cleanest to use string literals > > for all URLs and hosts in these tests, instead of string constants that are > > defined all over the place. > > Actually, if kDefaultURL is required by the test harness, I'd just add: > > const char[] kHttpURLFromAnotherOrigin = "http://www.example2.com/a.dat"; > const char[] kHttpsURLFromAnotherOrigin = ... > > and extract the origin from one of these as needed. Done.
lgtm, with nit. https://codereview.chromium.org/1545403002/diff/120001/net/spdy/spdy_session_... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/120001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4939: const char kHttpURLFromAnotherOrigin[] = "http://www.example2.org/a.dat"; nit: I'd move these constants to an anonymous namespace in this file so they don't have to be defined repeatedly.
tbansal@chromium.org changed reviewers: + mmenke@chromium.org
mmenke: PTAL. Thanks. https://codereview.chromium.org/1545403002/diff/120001/net/spdy/spdy_session_... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/120001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4939: const char kHttpURLFromAnotherOrigin[] = "http://www.example2.org/a.dat"; On 2016/01/11 21:57:12, bengr wrote: > nit: I'd move these constants to an anonymous namespace in this file so they > don't have to be defined repeatedly. Done.
mmenke@chromium.org changed reviewers: + bnc@chromium.org
Redirecting to Bence, the HTTP2 owner.
mmenke@chromium.org changed reviewers: - mmenke@chromium.org
LGTM. https://codereview.chromium.org/1545403002/diff/140001/net/spdy/spdy_session_... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/140001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4872: scoped_ptr<SpdyFrame> request( The name |req| is used everywhere in this file, please rename for consistency. https://codereview.chromium.org/1545403002/diff/140001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4874: scoped_ptr<SpdyFrame> reset( The name |rst| is used everywhere in this file, please rename for consistency.
https://codereview.chromium.org/1545403002/diff/140001/net/spdy/spdy_session_... File net/spdy/spdy_session_unittest.cc (right): https://codereview.chromium.org/1545403002/diff/140001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4872: scoped_ptr<SpdyFrame> request( On 2016/01/12 13:10:19, Bence wrote: > The name |req| is used everywhere in this file, please rename for consistency. Done. https://codereview.chromium.org/1545403002/diff/140001/net/spdy/spdy_session_... net/spdy/spdy_session_unittest.cc:4874: scoped_ptr<SpdyFrame> reset( On 2016/01/12 13:10:19, Bence wrote: > The name |rst| is used everywhere in this file, please rename for consistency. Done.
The CQ bit was checked by tbansal@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org, bnc@chromium.org Link to the patchset: https://codereview.chromium.org/1545403002/#ps160001 (title: "Addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545403002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545403002/160001
Message was sent while issue was closed.
Description was changed from ========== Return false when trusted SPDY proxy advertises HTTPS URL. Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross- origin push by a trusted SPDY proxy advertises an HTTPS URL. Also, add tests that verify the correctness of trusted SPDY proxy. BUG=572766, 572767 ========== to ========== Return false when trusted SPDY proxy advertises HTTPS URL. Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross- origin push by a trusted SPDY proxy advertises an HTTPS URL. Also, add tests that verify the correctness of trusted SPDY proxy. BUG=572766, 572767 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Return false when trusted SPDY proxy advertises HTTPS URL. Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross- origin push by a trusted SPDY proxy advertises an HTTPS URL. Also, add tests that verify the correctness of trusted SPDY proxy. BUG=572766, 572767 ========== to ========== Return false when trusted SPDY proxy advertises HTTPS URL. Adds a missing return statement so that SpdySession::TryCreatePushStream returns false when a cross- origin push by a trusted SPDY proxy advertises an HTTPS URL. Also, add tests that verify the correctness of trusted SPDY proxy. BUG=572766, 572767 Committed: https://crrev.com/fa4a762f62a3f22c0df12b698c43ea413ec4ebfb Cr-Commit-Position: refs/heads/master@{#368973} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/fa4a762f62a3f22c0df12b698c43ea413ec4ebfb Cr-Commit-Position: refs/heads/master@{#368973} |
