Return false when trusted SPDY proxy advertises HTTPS URL

net/spdy/spdy_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <utility>
@@ skipping 2713 matching lines @@
   // that is trusted explicitly via the --trusted-spdy-proxy switch.
   if (trusted_spdy_proxy_.Equals(host_port_pair())) {
     // Disallow pushing of HTTPS content.
     if (gurl.SchemeIs("https")) {
       EnqueueResetStreamFrame(
           stream_id,
           request_priority,
           RST_STREAM_REFUSED_STREAM,
           base::StringPrintf("Rejected push of Cross Origin HTTPS content %d",
                              associated_stream_id));
+      return false;

[bengr, 2015/12/29 18:02:33]

Please explain this in much more detail. Update the CL description, please.

[tbansal1, 2015/12/30 00:00:52]

Added CL description. This function is expected to return false when the push
stream is not created.

     }
   } else {
     GURL associated_url(associated_it->second.stream->GetUrlFromHeaders());
     if (associated_url.GetOrigin() != gurl.GetOrigin()) {
       EnqueueResetStreamFrame(
           stream_id,
           request_priority,
           RST_STREAM_REFUSED_STREAM,
           base::StringPrintf("Rejected Cross Origin Push Stream %d",
                              associated_stream_id));
@@ skipping 586 matching lines @@
     if (!queue->empty()) {
       SpdyStreamId stream_id = queue->front();
       queue->pop_front();
       return stream_id;
     }
   }
   return 0;
 }
 
 }  // namespace net