Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Issue 15405006: Modify AnimationEffect::sample() to return a CompositableValue (Closed)

Created:
7 years, 7 months ago by Steve Block
Modified:
7 years, 7 months ago
Reviewers:
dstockwell, shans
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, darktears, Steve Block, alancutter (OOO until 2018)
Visibility:
Public.

Description

Modify AnimationEffect::sample() to return a CompositableValue CompositableValue encapsulates the value which results from applying a set of composition operations onto an underlying value. It is used to represent the output of the effect phase of the Web Animations model. This patch also introduces a stub implementation of AnimatableValue. It also makes AnimationEffect an interface and moves the current dummy implementation to DocmentTimelineTest. BUG=240653 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150741

Patch Set 1 #

Patch Set 2 : Add some comments and fix EmptyAnimationEffect #

Patch Set 3 : Trivial style fix #

Patch Set 4 : Rebased #

Patch Set 5 : Fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -98 lines) Patch
A Source/core/animation/AnimatableValue.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A + Source/core/animation/AnimatableValue.cpp View 1 chunk +5 lines, -16 lines 0 comments Download
M Source/core/animation/Animation.h View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/animation/Animation.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationEffect.h View 1 1 chunk +17 lines, -10 lines 0 comments Download
D Source/core/animation/AnimationEffect.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
M Source/core/animation/DocumentTimelineTest.cpp View 1 2 3 1 chunk +16 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Steve Block
7 years, 7 months ago (2013-05-20 00:24:05 UTC) #1
shans
On 2013/05/20 00:24:05, Steve Block wrote: LGTM, FWIW
7 years, 7 months ago (2013-05-20 23:26:37 UTC) #2
dstockwell
lgtm
7 years, 7 months ago (2013-05-20 23:34:48 UTC) #3
commit-bot: I haz the power
No reviewers yet.
7 years, 7 months ago (2013-05-21 03:30:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/15405006/9001
7 years, 7 months ago (2013-05-21 03:36:02 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/animation/Animation.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-21 03:36:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/15405006/19001
7 years, 7 months ago (2013-05-21 03:57:14 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 05:16:07 UTC) #8
Message was sent while issue was closed.
Change committed as 150741

Powered by Google App Engine
This is Rietveld 408576698