Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: Source/core/animation/AnimationEffect.h

Issue 15405006: Modify AnimationEffect::sample() to return a CompositableValue (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/Animation.cpp ('k') | Source/core/animation/AnimationEffect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimationEffect.h
diff --git a/Source/core/animation/AnimationEffect.h b/Source/core/animation/AnimationEffect.h
index 68c9497b5046e4512888dd3b156df8feff3f4ee1..c39aff201b9785d5b859451dc54c288b00c72e9d 100644
--- a/Source/core/animation/AnimationEffect.h
+++ b/Source/core/animation/AnimationEffect.h
@@ -31,22 +31,29 @@
#ifndef AnimationEffect_h
#define AnimationEffect_h
-#include <wtf/PassRefPtr.h>
-#include <wtf/RefCounted.h>
+#include "CSSPropertyNames.h"
+#include "wtf/HashMap.h"
+#include "wtf/PassOwnPtr.h"
+#include "wtf/RefCounted.h"
namespace WebCore {
-class StylePropertySet;
+class AnimatableValue;
class AnimationEffect : public RefCounted<AnimationEffect> {
-
public:
- static PassRefPtr<AnimationEffect> create();
-
- PassRefPtr<StylePropertySet> sample(double fraction, int iteration);
-
-private:
- AnimationEffect();
+ // Encapsulates the value which results from applying a set of composition operations onto an
+ // underlying value. It is used to represent the output of the effect phase of the Web
+ // Animations model.
+ class CompositableValue : public RefCounted<CompositableValue> {
+ public:
+ virtual ~CompositableValue() { }
+ virtual AnimatableValue composite(const AnimatableValue&) const = 0;
+ };
+
+ virtual ~AnimationEffect() { }
+ typedef HashMap<CSSPropertyID, RefPtr<CompositableValue> > CompositableValueMap;
+ virtual PassOwnPtr<CompositableValueMap> sample(int iteration, double fraction) const = 0;
};
} // namespace WebCore
« no previous file with comments | « Source/core/animation/Animation.cpp ('k') | Source/core/animation/AnimationEffect.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698