Issue 15358006: Moving ICU constants to separate OBJ for split-link

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15358006: Moving ICU constants to separate OBJ for split-link (Closed)

Created:
7 years, 7 months ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 7 months ago

Reviewers:
brettw, scottmg

CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Moving ICU constants to separate OBJ for split-link Else the exports are not just functions and that causes problems in split link mode. NOTRY=true TBR=brettw BUG=237249 TEST=it builds Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201399

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -18 lines)			Patch
M	base/base.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	base/i18n/i18n_constants.h	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
A +	base/i18n/i18n_constants.cc	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download
M	base/i18n/icu_string_conversions.h	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	base/i18n/icu_string_conversions.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	build/split_link_partition.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/15358006/3001

7 years, 7 months ago (2013-05-21 20:34:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/15358006/15001

7 years, 7 months ago (2013-05-21 23:05:10 UTC) #4

Message was sent while issue was closed.

Change committed as 201399