Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2912)

Unified Diff: base/i18n/icu_string_conversions.h

Issue 15358006: Moving ICU constants to separate OBJ for split-link (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add split link file Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/i18n/i18n_constants.cc ('k') | base/i18n/icu_string_conversions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/i18n/icu_string_conversions.h
diff --git a/base/i18n/icu_string_conversions.h b/base/i18n/icu_string_conversions.h
index 31a57df0043bc4c85fdd77a11b2cd895cd4cb752..24b687dbf297420785f3760e6d15275e81018f25 100644
--- a/base/i18n/icu_string_conversions.h
+++ b/base/i18n/icu_string_conversions.h
@@ -8,6 +8,7 @@
#include <string>
#include "base/i18n/base_i18n_export.h"
+#include "base/i18n/i18n_constants.h"
#include "base/string16.h"
namespace base {
@@ -34,12 +35,6 @@ class OnStringConversionError {
OnStringConversionError();
};
-// Names of codepages (charsets) understood by icu.
-BASE_I18N_EXPORT extern const char kCodepageLatin1[]; // a.k.a. ISO 8859-1
-BASE_I18N_EXPORT extern const char kCodepageUTF8[];
-BASE_I18N_EXPORT extern const char kCodepageUTF16BE[];
-BASE_I18N_EXPORT extern const char kCodepageUTF16LE[];
-
// Converts between UTF-16 strings and the encoding specified. If the
// encoding doesn't exist or the encoding fails (when on_error is FAIL),
// returns false.
« no previous file with comments | « base/i18n/i18n_constants.cc ('k') | base/i18n/icu_string_conversions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698