base/i18n/icu_string_conversions.cc - Issue 15358006: Moving ICU constants to separate OBJ for split-link

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/i18n/icu_string_conversions.cc

Issue 15358006: Moving ICU constants to separate OBJ for split-link (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add split link file Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/i18n/icu_string_conversions.cc

diff --git a/base/i18n/icu_string_conversions.cc b/base/i18n/icu_string_conversions.cc

index 2ff5009b120ab36534c7a94e6b9f31ec20e90fea..292d614d62796c33c7eafbecbfaef49e3296e4b9 100644

--- a/base/i18n/icu_string_conversions.cc

+++ b/base/i18n/icu_string_conversions.cc

@@ -144,11 +144,6 @@ inline UConverterType utf32_platform_endian() {

} // namespace

-const char kCodepageLatin1[] = "ISO-8859-1";

-const char kCodepageUTF8[] = "UTF-8";

-const char kCodepageUTF16BE[] = "UTF-16BE";

-const char kCodepageUTF16LE[] = "UTF-16LE";

// Codepage <-> Wide/UTF-16 ---------------------------------------------------

bool UTF16ToCodepage(const string16& utf16,

« no previous file with comments | « base/i18n/icu_string_conversions.h ('k') | build/split_link_partition.py » ('j') | no next file with comments »