Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 15314003: Add methods to SkLayerDrawLooper to allow adding layers on top (Closed)

Created:
7 years, 7 months ago by jbroman
Modified:
7 years, 7 months ago
Reviewers:
Tom Hudson, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add methods to SkLayerDrawLooper to allow adding layers on top as well as on the bottom. This is more convenient for some callers who generate layers from a data structure in bottom-to-top, rather than top-to-bottom, order. BUG=242529 Committed: http://code.google.com/p/skia/source/detail?r=9233

Patch Set 1 #

Patch Set 2 : fix SkFlattenableReadBuffer constructor and remove Rec::Reverse, which is unnecessary #

Patch Set 3 : Change upstream #

Patch Set 4 : tweaks for style #

Patch Set 5 : add a test #

Total comments: 5

Patch Set 6 : changes requested by tomhudson #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -18 lines) Patch
M gyp/tests.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkLayerDrawLooper.h View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 2 3 6 chunks +23 lines, -16 lines 0 comments Download
A tests/LayerDrawLooperTest.cpp View 1 2 3 4 5 1 chunk +154 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbroman
7 years, 7 months ago (2013-05-21 17:19:52 UTC) #1
Tom Hudson
Thanks for adding a unit test. LGTM modulo nit https://codereview.chromium.org/15314003/diff/8001/include/effects/SkLayerDrawLooper.h File include/effects/SkLayerDrawLooper.h (right): https://codereview.chromium.org/15314003/diff/8001/include/effects/SkLayerDrawLooper.h#newcode102 include/effects/SkLayerDrawLooper.h:102: ...
7 years, 7 months ago (2013-05-22 09:46:04 UTC) #2
jbroman
https://codereview.chromium.org/15314003/diff/8001/include/effects/SkLayerDrawLooper.h File include/effects/SkLayerDrawLooper.h (right): https://codereview.chromium.org/15314003/diff/8001/include/effects/SkLayerDrawLooper.h#newcode102 include/effects/SkLayerDrawLooper.h:102: // Similar to addLayer, but adds a layer to ...
7 years, 7 months ago (2013-05-22 12:18:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jbroman@chromium.org/15314003/13001
7 years, 7 months ago (2013-05-22 12:21:47 UTC) #4
commit-bot: I haz the power
Change committed as 9233
7 years, 7 months ago (2013-05-22 12:35:53 UTC) #5
reed1
7 years, 7 months ago (2013-05-22 13:46:41 UTC) #6
Message was sent while issue was closed.
nice change

Powered by Google App Engine
This is Rietveld 408576698