Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15232002: Make remaining modules/ objects ScriptWrappable (Closed)

Created:
7 years, 7 months ago by Tom Sepez
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, kinuko, eae+blinkwatch
Visibility:
Public.

Description

Make remaining modules/ objects ScriptWrappable BUG=236671 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -22 lines) Patch
M Source/modules/gamepad/Gamepad.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/gamepad/Gamepad.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/gamepad/GamepadList.h View 3 chunks +7 lines, -2 lines 0 comments Download
M Source/modules/geolocation/Coordinates.h View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/modules/geolocation/Geoposition.h View 3 chunks +5 lines, -3 lines 0 comments Download
M Source/modules/notifications/Notification.h View 7 chunks +8 lines, -7 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/modules/notifications/NotificationCenter.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/notifications/NotificationCenter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/StorageInfo.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/quota/StorageInfo.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/StorageQuota.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/quota/StorageQuota.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/AudioParam.h View 3 chunks +3 lines, -1 line 0 comments Download
M Source/modules/webmidi/MIDIInput.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIOutput.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIPort.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webmidi/MIDIPort.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/websockets/WebSocket.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
Adam, please review. I have run the Debug tests locally on my linux box without ...
7 years, 7 months ago (2013-05-16 19:19:37 UTC) #1
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-16 19:29:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/15232002/1
7 years, 7 months ago (2013-05-16 19:31:23 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 20:14:48 UTC) #4
Message was sent while issue was closed. 
Change committed as 150533

Powered by Google App Engine
This is Rietveld 408576698