Grab bag of clang fixes for Windows code

Grab bag of clang fixes for Windows code

These should hopefully be uncontroversial, so I'm sending them to Darin
because he has global OWNERS approval on src/*.  Let me know if you want
to split this up and farm it out to individual components.

R=darin@chromium.org
CC=thakis@chromium.org
BUG=82385
Fix some -Wdeprecated-writable-strings warnings for wide string
literals.
  net/dns/dns_config_service_win_unittest.cc
  net/http/http_auth_sspi_win.cc
  net/http/http_auth_sspi_win.h
  ui/shell_dialogs/select_file_dialog_win_unittest.cc

Use reinterpret_cast<> to convert from void * to a function pointer.
  chrome/browser/policy/policy_loader_win.cc
  content/browser/gamepad/gamepad_platform_data_fetcher_win.cc

Remove "public" from a typedef.  It's not clear that that really means.
  chrome/browser/enumerate_modules_model_unittest_win.cc

Escape an unescaped backslash in a wide string iteral to prevent it from
being interpreted as a unicode literal ("\uXXX").
  chrome/browser/storage_monitor/test_portable_device_watcher_win.cc

Use base::UTF8ToUTF16() over ATL::CA2W() and avoid an unnecessary
c_str().  Clang can't convert from CA2WEX<> to string16.
  chrome/browser/ui/views/external_tab_container_win.cc

Fix a -Wenum-compare warning when asserting that two enum values are
equal.
  sandbox/win/src/policy_params.h

Don't define va_copy for clang.  It provides one in <stdarg.h>.
  third_party/leveldatabase/port/port_chromium.h

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200814

[darin (slow to review), 2013-05-16 20:06:54]

LGTM

[mmenke, 2013-05-16 21:58:45]

https://codereview.chromium.org/15200005/diff/4001/net/dns/dns_config_service...
File net/dns/dns_config_service_win_unittest.cc (right):

https://codereview.chromium.org/15200005/diff/4001/net/dns/dns_config_service...
net/dns/dns_config_service_win_unittest.cc:55: const WCHAR *dns_suffix;
Per Google style guide, this should be "const WCHAR* dns_suffix;"

https://codereview.chromium.org/15200005/diff/4001/sandbox/win/src/policy_par...
File sandbox/win/src/policy_params.h (right):

https://codereview.chromium.org/15200005/diff/4001/sandbox/win/src/policy_par...
sandbox/win/src/policy_params.h:36: COMPILE_ASSERT(OpenFile::BROKER ==
(int)FileName::BROKER,
C-style casts violate Google style guide.

[Reid Kleckner, 2013-05-16 23:01:02]

Fixed comments.  Thanks for the review, committing.

[commit-bot: I haz the power, 2013-05-16 23:01:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rnk@chromium.org/15200005/10001

[commit-bot: I haz the power, 2013-05-17 01:46:36]

Retried try job too often on win_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-17 12:13:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rnk@chromium.org/15200005/10001

[commit-bot: I haz the power, 2013-05-17 14:01:19]

Change committed as 200814