Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: chrome/browser/ui/views/external_tab_container_win.cc

Issue 15200005: Grab bag of clang fixes for Windows code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix ptr and cast style Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/external_tab_container_win.h" 5 #include "chrome/browser/ui/views/external_tab_container_win.h"
6 6
7 #include <atlbase.h> 7 #include <atlbase.h>
8 #include <atlapp.h> 8 #include <atlapp.h>
9 #include <atlconv.h> 9 #include <atlconv.h>
10 #include <atlcrack.h> 10 #include <atlcrack.h>
(...skipping 722 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 } 733 }
734 734
735 bool ExternalTabContainerWin::IsPopupOrPanel(const WebContents* source) const { 735 bool ExternalTabContainerWin::IsPopupOrPanel(const WebContents* source) const {
736 return is_popup_window_; 736 return is_popup_window_;
737 } 737 }
738 738
739 void ExternalTabContainerWin::UpdateTargetURL(WebContents* source, 739 void ExternalTabContainerWin::UpdateTargetURL(WebContents* source,
740 int32 page_id, 740 int32 page_id,
741 const GURL& url) { 741 const GURL& url) {
742 if (automation_) { 742 if (automation_) {
743 string16 url_string = CA2W(url.spec().c_str()); 743 string16 url_string = base::UTF8ToUTF16(url.spec());
744 automation_->Send( 744 automation_->Send(
745 new AutomationMsg_UpdateTargetUrl(tab_handle_, url_string)); 745 new AutomationMsg_UpdateTargetUrl(tab_handle_, url_string));
746 } 746 }
747 } 747 }
748 748
749 void ExternalTabContainerWin::ContentsZoomChange(bool zoom_in) { 749 void ExternalTabContainerWin::ContentsZoomChange(bool zoom_in) {
750 } 750 }
751 751
752 bool ExternalTabContainerWin::TakeFocus(content::WebContents* source, 752 bool ExternalTabContainerWin::TakeFocus(content::WebContents* source,
753 bool reverse) { 753 bool reverse) {
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
1397 if (params.disposition == CURRENT_TAB) { 1397 if (params.disposition == CURRENT_TAB) {
1398 DCHECK(route_all_top_level_navigations_); 1398 DCHECK(route_all_top_level_navigations_);
1399 forward_params.disposition = NEW_FOREGROUND_TAB; 1399 forward_params.disposition = NEW_FOREGROUND_TAB;
1400 } 1400 }
1401 WebContents* new_contents = 1401 WebContents* new_contents =
1402 ExternalTabContainerWin::OpenURLFromTab(source, forward_params); 1402 ExternalTabContainerWin::OpenURLFromTab(source, forward_params);
1403 // support only one navigation for a dummy tab before it is killed. 1403 // support only one navigation for a dummy tab before it is killed.
1404 widget_->CloseNow(); 1404 widget_->CloseNow();
1405 return new_contents; 1405 return new_contents;
1406 } 1406 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698