[InfoBar] Add InfoBarDelegate::GetIconID()

[InfoBar] Add InfoBarDelegate::GetIconID()

Splits apart the GetIcon() call to allow accessing the ID of the resource in
addition to the loaded image.  This is needed so that the Android port can
determine which of the Java-side resources it needs to load for its UI.

* GetIconID() is a function that gets overridden by subclasses instead of
  GetIcon().  GetIconID() returns the IDR_* tag that represents the icon that
  it would normally load.

* GetIcon() now calls GetIconID() and shouldn't be overridden.

* Small change to the SimpleAlertInfoBarDelegate::Create() call to account
for invalid icon IDs (was NULL for bitmaps, 0 for non-existent icons).

BUG=237034
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200598

[gone, 2013-05-11 00:41:26]

Hey all,
This CL is a stepping stone to getting properly sized resources on Android;
we're currently stuck scaling up a bunch of things (most notably InfoBars)
because the Java app doesn't know anything except that it needs to display a
Bitmap (of something).  As prep work for passing this information up, I've
changed how InfoBarDelegate::GetIcon() is defined so that we can grab the icon's
resource as needed.

Please let me know if you've got any questions, or if someone else is better
suited for the review.

Thanks!
Dan

[tfarina, 2013-05-11 00:44:23]

https://chromiumcodereview.appspot.com/15067008/diff/19001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/19001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.h:87: gfx::Image* GetIcon() const;
if you kept the virtual, you could annotate this method as FINAL (see
base/compiler_specific.h), but if seems it doesn't need to be virtual anymore.

[gone, 2013-05-11 00:48:24]

https://chromiumcodereview.appspot.com/15067008/diff/19001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/19001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.h:87: gfx::Image* GetIcon() const;
On 2013/05/11 00:44:23, tfarina wrote:
> if you kept the virtual, you could annotate this method as FINAL (see
> base/compiler_specific.h), but if seems it doesn't need to be virtual anymore.

Yeah, it turns out that all of the GetIcon() calls were doing the exact same
thing, but with different resource IDs.  I thought it would make more sense to
make that part of it virtual (in GetIconID()) and move the loading call here.

[Jói, 2013-05-11 12:04:11]

Hi Dan,

You have three reviewers listed; can you specify which bits you wanted
which of us to review?

Cheers,
Jói


On Sat, May 11, 2013 at 1:41 AM,  <dfalcantara@chromium.org> wrote:
> Reviewers: Peter Kasting, Jói, sky,
>
> Message:
> Hey all,
> This CL is a stepping stone to getting properly sized resources on Android;
> we're currently stuck scaling up a bunch of things (most notably InfoBars)
> because the Java app doesn't know anything except that it needs to display a
> Bitmap (of something).  As prep work for passing this information up, I've
> changed how InfoBarDelegate::GetIcon() is defined so that we can grab the
> icon's
> resource as needed.
>
> Please let me know if you've got any questions, or if someone else is better
> suited for the review.
>
> Thanks!
> Dan
>
> Description:
> [InfoBar] Add InfoBarDelegate::GetIconID()
>
> Splits apart the GetIcon() call to allow accessing the ID of the resource in
> addition to the loaded image.  This is needed so that the Android port can
> determine which of the Java-side resources it needs to load for its UI.
>
> * GetIconID() is a function that gets overridden by subclasses instead of
>   GetIcon().  GetIconID() returns the IDR_* tag that represents the icon
> that
>   it would normally load.
>
> * GetIcon() now calls GetIconID() and shouldn't be overridden.
>
> BUG=237034
>
> Please review this at https://chromiumcodereview.appspot.com/15067008/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files:
>   M chrome/browser/accessibility/accessibility_extension_apitest.cc
>   M chrome/browser/autofill/autofill_cc_infobar_delegate.h
>   M chrome/browser/autofill/autofill_cc_infobar_delegate.cc
>   M chrome/browser/download/download_request_infobar_delegate.h
>   M chrome/browser/download/download_request_infobar_delegate.cc
>   M chrome/browser/extensions/theme_installed_infobar_delegate.h
>   M chrome/browser/extensions/theme_installed_infobar_delegate.cc
>   M chrome/browser/geolocation/geolocation_infobar_delegate.h
>   M chrome/browser/geolocation/geolocation_infobar_delegate.cc
>   M chrome/browser/infobars/infobar_delegate.h
>   M chrome/browser/infobars/infobar_delegate.cc
>   M chrome/browser/infobars/simple_alert_infobar_delegate.h
>   M chrome/browser/infobars/simple_alert_infobar_delegate.cc
>   M chrome/browser/managed_mode/managed_mode_navigation_observer.cc
>   M chrome/browser/media/media_stream_infobar_delegate.h
>   M chrome/browser/media/media_stream_infobar_delegate.cc
>   M chrome/browser/notifications/desktop_notification_service.cc
>   M chrome/browser/omnibox_search_hint.cc
>   M chrome/browser/password_manager/password_manager_delegate_impl.cc
>   M chrome/browser/pepper_broker_infobar_delegate.h
>   M chrome/browser/pepper_broker_infobar_delegate.cc
>   M chrome/browser/plugins/plugin_infobar_delegates.h
>   M chrome/browser/plugins/plugin_infobar_delegates.cc
>   M chrome/browser/plugins/plugin_observer.cc
>   M chrome/browser/ssl/ssl_tab_helper.cc
>   M chrome/browser/translate/translate_infobar_delegate.h
>   M chrome/browser/translate/translate_infobar_delegate.cc
>   M chrome/browser/ui/auto_login_infobar_delegate.h
>   M chrome/browser/ui/auto_login_infobar_delegate.cc
>   M chrome/browser/ui/browser.cc
>   M chrome/browser/ui/chrome_select_file_policy.cc
>   M chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.h
>   M chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc
>   M chrome/browser/ui/cocoa/keystone_infobar_delegate.mm
>   M chrome/browser/ui/collected_cookies_infobar_delegate.h
>   M chrome/browser/ui/collected_cookies_infobar_delegate.cc
>   M
> chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate.h
>   M
>
chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate.cc
>   M
>
chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate_unittest.cc
>   M chrome/browser/ui/extensions/app_metro_infobar_delegate_win.h
>   M chrome/browser/ui/extensions/app_metro_infobar_delegate_win.cc
>   M chrome/browser/ui/hung_plugin_tab_helper.cc
>   M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h
>   M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc
>   M chrome/browser/ui/startup/autolaunch_prompt_win.cc
>   M chrome/browser/ui/startup/bad_flags_prompt.cc
>   M chrome/browser/ui/startup/default_browser_prompt.cc
>   M chrome/browser/ui/startup/session_crashed_prompt.h
>   M chrome/browser/ui/startup/session_crashed_prompt.cc
>   M chrome/browser/ui/website_settings/website_settings_infobar_delegate.h
>   M chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc
>
>

[gone, 2013-05-11 17:22:22]

I'm honestly not sure who's the best to review it; the main change is actually
in chrome/browser/infobars/, with all of the other changes in the directories
basically boiling down to replacing the old GetIcon() function with the new
GetIconID() function.

I think that pkasting@ is the main owner of that directory, but I believe you
two have also done some reviews in there.  If you'd like to punt, please feel
free.

On 2013/05/11 12:04:11, Jói wrote:
> Hi Dan,
> 
> You have three reviewers listed; can you specify which bits you wanted
> which of us to review?
> 
> Cheers,
> Jói
> 
> 
> On Sat, May 11, 2013 at 1:41 AM,  <mailto:dfalcantara@chromium.org> wrote:
> > Reviewers: Peter Kasting, Jói, sky,
> >
> > Message:
> > Hey all,
> > This CL is a stepping stone to getting properly sized resources on Android;
> > we're currently stuck scaling up a bunch of things (most notably InfoBars)
> > because the Java app doesn't know anything except that it needs to display a
> > Bitmap (of something).  As prep work for passing this information up, I've
> > changed how InfoBarDelegate::GetIcon() is defined so that we can grab the
> > icon's
> > resource as needed.
> >
> > Please let me know if you've got any questions, or if someone else is better
> > suited for the review.
> >
> > Thanks!
> > Dan
> >
> > Description:
> > [InfoBar] Add InfoBarDelegate::GetIconID()
> >
> > Splits apart the GetIcon() call to allow accessing the ID of the resource in
> > addition to the loaded image.  This is needed so that the Android port can
> > determine which of the Java-side resources it needs to load for its UI.
> >
> > * GetIconID() is a function that gets overridden by subclasses instead of
> >   GetIcon().  GetIconID() returns the IDR_* tag that represents the icon
> > that
> >   it would normally load.
> >
> > * GetIcon() now calls GetIconID() and shouldn't be overridden.
> >
> > BUG=237034
> >
> > Please review this at https://chromiumcodereview.appspot.com/15067008/
> >
> > SVN Base: https://chromium.googlesource.com/chromium/src.git%40master
> >
> > Affected files:
> >   M chrome/browser/accessibility/accessibility_extension_apitest.cc
> >   M chrome/browser/autofill/autofill_cc_infobar_delegate.h
> >   M chrome/browser/autofill/autofill_cc_infobar_delegate.cc
> >   M chrome/browser/download/download_request_infobar_delegate.h
> >   M chrome/browser/download/download_request_infobar_delegate.cc
> >   M chrome/browser/extensions/theme_installed_infobar_delegate.h
> >   M chrome/browser/extensions/theme_installed_infobar_delegate.cc
> >   M chrome/browser/geolocation/geolocation_infobar_delegate.h
> >   M chrome/browser/geolocation/geolocation_infobar_delegate.cc
> >   M chrome/browser/infobars/infobar_delegate.h
> >   M chrome/browser/infobars/infobar_delegate.cc
> >   M chrome/browser/infobars/simple_alert_infobar_delegate.h
> >   M chrome/browser/infobars/simple_alert_infobar_delegate.cc
> >   M chrome/browser/managed_mode/managed_mode_navigation_observer.cc
> >   M chrome/browser/media/media_stream_infobar_delegate.h
> >   M chrome/browser/media/media_stream_infobar_delegate.cc
> >   M chrome/browser/notifications/desktop_notification_service.cc
> >   M chrome/browser/omnibox_search_hint.cc
> >   M chrome/browser/password_manager/password_manager_delegate_impl.cc
> >   M chrome/browser/pepper_broker_infobar_delegate.h
> >   M chrome/browser/pepper_broker_infobar_delegate.cc
> >   M chrome/browser/plugins/plugin_infobar_delegates.h
> >   M chrome/browser/plugins/plugin_infobar_delegates.cc
> >   M chrome/browser/plugins/plugin_observer.cc
> >   M chrome/browser/ssl/ssl_tab_helper.cc
> >   M chrome/browser/translate/translate_infobar_delegate.h
> >   M chrome/browser/translate/translate_infobar_delegate.cc
> >   M chrome/browser/ui/auto_login_infobar_delegate.h
> >   M chrome/browser/ui/auto_login_infobar_delegate.cc
> >   M chrome/browser/ui/browser.cc
> >   M chrome/browser/ui/chrome_select_file_policy.cc
> >   M chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.h
> >   M chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc
> >   M chrome/browser/ui/cocoa/keystone_infobar_delegate.mm
> >   M chrome/browser/ui/collected_cookies_infobar_delegate.h
> >   M chrome/browser/ui/collected_cookies_infobar_delegate.cc
> >   M
> >
chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate.h
> >   M
> >
> chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate.cc
> >   M
> >
>
chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate_unittest.cc
> >   M chrome/browser/ui/extensions/app_metro_infobar_delegate_win.h
> >   M chrome/browser/ui/extensions/app_metro_infobar_delegate_win.cc
> >   M chrome/browser/ui/hung_plugin_tab_helper.cc
> >   M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h
> >   M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc
> >   M chrome/browser/ui/startup/autolaunch_prompt_win.cc
> >   M chrome/browser/ui/startup/bad_flags_prompt.cc
> >   M chrome/browser/ui/startup/default_browser_prompt.cc
> >   M chrome/browser/ui/startup/session_crashed_prompt.h
> >   M chrome/browser/ui/startup/session_crashed_prompt.cc
> >   M chrome/browser/ui/website_settings/website_settings_infobar_delegate.h
> >   M chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc
> >
> >

[tfarina, 2013-05-11 19:31:38]

Yes, Peter took infobars and since then he is the main reviewer/OWNER for API
changes there.

So I think you should wait for his review and after that you can ask
chrome/OWNERS (sky?) to rubber stamp the rest.

Thanks!

[Peter Kasting, 2013-05-14 00:50:49]

Rubber-stamp LGTM.  I did not review code outside infobar_delegate.* except for
a few spot checks.  Let me know if you need a more thorough review.

https://chromiumcodereview.appspot.com/15067008/diff/30001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.cc (right):

https://chromiumcodereview.appspot.com/15067008/diff/30001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.cc:50: } else {
Nit: No else after return.  Do this:

  int icon_id = GetIconID();
  return (icon_id == -1) ?
      NULL : &ResourceBundle::GetSharedInstance().GetNativeImageNamed(icon_id);

https://chromiumcodereview.appspot.com/15067008/diff/30001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/30001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.h:87: gfx::Image* GetIcon() const;
Nit: Move this function below the other public functions (also in the .cc file)
since it is not virtual.

[gone, 2013-05-14 17:50:17]

Thanks!  Added sky@ to get through the rest of the directories.

Sky: the changes in the files outside of infobars/ boil down to replacing the
GetIcon() functions with GetIconID() functions.

https://chromiumcodereview.appspot.com/15067008/diff/30001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.cc (right):

https://chromiumcodereview.appspot.com/15067008/diff/30001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.cc:50: } else {
On 2013/05/14 00:50:50, Peter Kasting wrote:
> Nit: No else after return.  Do this:
> 
>   int icon_id = GetIconID();
>   return (icon_id == -1) ?
>       NULL :
&ResourceBundle::GetSharedInstance().GetNativeImageNamed(icon_id);

Done.

https://chromiumcodereview.appspot.com/15067008/diff/30001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/30001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.h:87: gfx::Image* GetIcon() const;
On 2013/05/14 00:50:50, Peter Kasting wrote:
> Nit: Move this function below the other public functions (also in the .cc
file)
> since it is not virtual.

Done.

[sky, 2013-05-14 21:02:02]

https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.h:107: // NULL, no icon is shown.
nit: document ownership here.

Is there a reason we don't return a gfx::Image here? That way no worries about
ownership.

[gone, 2013-05-14 22:31:43]

https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.h:107: // NULL, no icon is shown.
I think it's because the ResourceBundle caches everything so that subsequent
loads of the same resource don't incur another loading penalty.  Added a comment
to that effect.

On 2013/05/14 21:02:03, sky wrote:
> nit: document ownership here.
> 
> Is there a reason we don't return a gfx::Image here? That way no worries about
> ownership.

[Peter Kasting, 2013-05-15 00:18:51]

https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.h:107: // NULL, no icon is shown.
On 2013/05/14 22:31:44, dfalcantara wrote:
> I think it's because the ResourceBundle caches everything so that subsequent
> loads of the same resource don't incur another loading penalty.

How does returning an Image instead of an Image* make much difference to that,
though?

Ans aren't Images supposed to be cheap to copy (because they refcount the
important underlying data)?

I'm a fan of not returning pointer types unless we have to; I didn't focus on it
because this wasn't a change from the old code, but perhaps it's worth looking
at since you're touching this anyway.

[gone, 2013-05-15 00:27:15]

On 2013/05/15 00:18:51, Peter Kasting wrote:
>
https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
> File chrome/browser/infobars/infobar_delegate.h (right):
> 
>
https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
> chrome/browser/infobars/infobar_delegate.h:107: // NULL, no icon is shown.
> On 2013/05/14 22:31:44, dfalcantara wrote:
> > I think it's because the ResourceBundle caches everything so that subsequent
> > loads of the same resource don't incur another loading penalty.
> 
> How does returning an Image instead of an Image* make much difference to that,
> though?
> 
> Ans aren't Images supposed to be cheap to copy (because they refcount the
> important underlying data)?
> 
> I'm a fan of not returning pointer types unless we have to; I didn't focus on
it
> because this wasn't a change from the old code, but perhaps it's worth looking
> at since you're touching this anyway.

What should the return value be here when an image couldn't be found, in that
case?

[gone, 2013-05-15 00:31:54]

On 2013/05/15 00:27:15, dfalcantara wrote:
> On 2013/05/15 00:18:51, Peter Kasting wrote:
> >
>
https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
> > File chrome/browser/infobars/infobar_delegate.h (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/15067008/diff/42001/chrome/browser/inf...
> > chrome/browser/infobars/infobar_delegate.h:107: // NULL, no icon is shown.
> > On 2013/05/14 22:31:44, dfalcantara wrote:
> > > I think it's because the ResourceBundle caches everything so that
subsequent
> > > loads of the same resource don't incur another loading penalty.
> > 
> > How does returning an Image instead of an Image* make much difference to
that,
> > though?
> > 
> > Ans aren't Images supposed to be cheap to copy (because they refcount the
> > important underlying data)?
> > 
> > I'm a fan of not returning pointer types unless we have to; I didn't focus
on
> it
> > because this wasn't a change from the old code, but perhaps it's worth
looking
> > at since you're touching this anyway.
> 
> What should the return value be here when an image couldn't be found, in that
> case?

Possibly Image::IsEmpty()?

[Peter Kasting, 2013-05-15 01:03:57]

On 2013/05/15 00:31:54, dfalcantara wrote:
> > What should the return value be here when an image couldn't be found, in
that
> > case?
> 
> Possibly Image::IsEmpty()?

Right, the assumption is that Image has a NULL constructor that results in a
valid object that can be distinguished from one actually containing image data.

[gone, 2013-05-15 19:37:51]

On 2013/05/15 01:03:57, Peter Kasting wrote:
> On 2013/05/15 00:31:54, dfalcantara wrote:
> > > What should the return value be here when an image couldn't be found, in
> that
> > > case?
> > 
> > Possibly Image::IsEmpty()?
> 
> Right, the assumption is that Image has a NULL constructor that results in a
> valid object that can be distinguished from one actually containing image
data.

Alright, I'm fairly certain I finally caught all of the uses and switched them
over...  PTAL.

[sky, 2013-05-15 20:47:06]

LGTM

https://chromiumcodereview.appspot.com/15067008/diff/94001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/94001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.h:103: static const int kNoIconID = 0;
nit: constants should be above destructor.

https://chromiumcodereview.appspot.com/15067008/diff/94001/chrome/browser/inf...
File chrome/browser/infobars/simple_alert_infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/94001/chrome/browser/inf...
chrome/browser/infobars/simple_alert_infobar_delegate.h:35: int icon_id_;
nit: make const if possible.

[gone, 2013-05-15 21:42:59]

Thanks!  Peter, is this good to go?

https://chromiumcodereview.appspot.com/15067008/diff/94001/chrome/browser/inf...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/94001/chrome/browser/inf...
chrome/browser/infobars/infobar_delegate.h:103: static const int kNoIconID = 0;
On 2013/05/15 20:47:06, sky wrote:
> nit: constants should be above destructor.

Done.

https://chromiumcodereview.appspot.com/15067008/diff/94001/chrome/browser/inf...
File chrome/browser/infobars/simple_alert_infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/94001/chrome/browser/inf...
chrome/browser/infobars/simple_alert_infobar_delegate.h:35: int icon_id_;
On 2013/05/15 20:47:06, sky wrote:
> nit: make const if possible.

Done.

[Peter Kasting, 2013-05-15 21:47:42]

LGTM

https://chromiumcodereview.appspot.com/15067008/diff/103001/chrome/browser/in...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/103001/chrome/browser/in...
chrome/browser/infobars/infobar_delegate.h:51: static const int kNoIconID = 0;
You may want to merely declare this here, and define it in the .cc file, in
order to prevent compilation issues on a few older compilers.  (This is our
typical pattern with Chrome constants.)

[gone, 2013-05-15 22:06:25]

Done, thanks!

https://chromiumcodereview.appspot.com/15067008/diff/103001/chrome/browser/in...
File chrome/browser/infobars/infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/15067008/diff/103001/chrome/browser/in...
chrome/browser/infobars/infobar_delegate.h:51: static const int kNoIconID = 0;
On 2013/05/15 21:47:43, Peter Kasting wrote:
> You may want to merely declare this here, and define it in the .cc file, in
> order to prevent compilation issues on a few older compilers.  (This is our
> typical pattern with Chrome constants.)

Done.

[commit-bot: I haz the power, 2013-05-15 22:07:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/15067008/1054

[commit-bot: I haz the power, 2013-05-16 05:10:34]

Retried try job too often on win_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-16 17:04:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/15067008/1054

[commit-bot: I haz the power, 2013-05-16 19:04:00]

Change committed as 200598