chrome/browser/geolocation/geolocation_browsertest.cc - Issue 15067008: [InfoBar] Add InfoBarDelegate::GetIconID()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_browsertest.cc

Issue 15067008: [InfoBar] Add InfoBarDelegate::GetIconID() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit fixes redux Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/geolocation/geolocation_browsertest.cc

diff --git a/chrome/browser/geolocation/geolocation_browsertest.cc b/chrome/browser/geolocation/geolocation_browsertest.cc

index cdf566acf6ac18c1644a5611fdb1db28036dcd61..8b715c7a0cbfc0d79502551171ce4e66124e8acc 100644

--- a/chrome/browser/geolocation/geolocation_browsertest.cc

+++ b/chrome/browser/geolocation/geolocation_browsertest.cc

@@ -175,7 +175,7 @@ void GeolocationNotificationObserver::Observe(

const content::NotificationDetails& details) {

if (type == chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED) {

infobar_ = content::Details<InfoBarAddedDetails>(details).ptr();

- ASSERT_TRUE(infobar_->GetIcon());

+ ASSERT_FALSE(infobar_->GetIcon().IsEmpty());

ASSERT_TRUE(infobar_->AsConfirmInfoBarDelegate());

} else if (type == content::NOTIFICATION_DOM_OPERATION_RESPONSE) {

content::Details<DomOperationNotificationDetails> dom_op_details(details);