Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: Source/WebKit/chromium/public/WebFrame.h

Issue 15017002: WebFrame::selectRange and moveCaret should behave like mouse selection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Move to method of VisibleSelection, fix style nits Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/WebFrameImpl.h » ('j') | Source/core/page/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/public/WebFrame.h
diff --git a/Source/WebKit/chromium/public/WebFrame.h b/Source/WebKit/chromium/public/WebFrame.h
index d1ff74278382763c6706b69e47c1914f47412161..19c0b6ffffd97c7fb1ca0fc84f15c8d0bbb0d72a 100644
--- a/Source/WebKit/chromium/public/WebFrame.h
+++ b/Source/WebKit/chromium/public/WebFrame.h
@@ -456,13 +456,16 @@ public:
// there is ranged selection.
virtual bool selectWordAroundCaret() = 0;
- // Select a range of text, as if by drag-selecting from base to extent
- // with character granularity.
+ // DEPRECATED: Use moveRangeSelection/moveCaretSelection.
virtual void selectRange(const WebPoint& base, const WebPoint& extent) = 0;
+ virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&) = 0;
virtual void selectRange(const WebRange&) = 0;
- virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&) = 0;
+ // Move the current selection. If the current selection is editable, the
+ // new selection will be restricted to the root editable element.
jamesr 2013/05/23 23:46:46 these points are still in Window coordinates, righ
+ virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent) = 0;
+ virtual void moveCaretSelection(const WebPoint&) = 0;
// Printing ------------------------------------------------------------
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/WebFrameImpl.h » ('j') | Source/core/page/EventHandler.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698