Source/WebKit/chromium/src/WebFrameImpl.h - Issue 15017002: WebFrame::selectRange and moveCaret should behave like mouse selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebFrameImpl.h

Issue 15017002: WebFrame::selectRange and moveCaret should behave like mouse selection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move to method of VisibleSelection, fix style nits Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebKit/chromium/src/WebFrameImpl.h

diff --git a/Source/WebKit/chromium/src/WebFrameImpl.h b/Source/WebKit/chromium/src/WebFrameImpl.h

index fee5e7ff1efd76a8946fc9d54c8622f6a120b669..e29114acc5d9344672664578ee079d45c4f03356 100644

--- a/Source/WebKit/chromium/src/WebFrameImpl.h

+++ b/Source/WebKit/chromium/src/WebFrameImpl.h

@@ -189,6 +189,8 @@ public:

virtual void selectRange(const WebPoint& base, const WebPoint& extent);

virtual void selectRange(const WebRange&);

virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&);

+ virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent);

+ virtual void moveCaretSelection(const WebPoint&);

virtual int printBegin(const WebPrintParams&,

const WebNode& constrainToNode,

bool* useBrowserOverlays);