WebFrame::selectRange and moveCaret should behave like mouse selection

Source/WebKit/chromium/public/WebFrame.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 438 matching lines @@
     virtual WebRange selectionRange() const = 0;
 
     virtual WebString selectionAsText() const = 0;
     virtual WebString selectionAsMarkup() const = 0;
 
     // Expands the selection to a word around the caret and returns
     // true. Does nothing and returns false if there is no caret or
     // there is ranged selection.
     virtual bool selectWordAroundCaret() = 0;
 
-    // Select a range of text, as if by drag-selecting from base to extent
-    // with character granularity.
+    // DEPRECATED: Use moveRangeSelection/moveCaretSelection.
     virtual void selectRange(const WebPoint& base, const WebPoint& extent) = 0;
+    virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&) = 0;
 
     virtual void selectRange(const WebRange&) = 0;
 
-    virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&) = 0;
+    // Move the current selection. If the current selection is editable, the
+    // new selection will be restricted to the root editable element.

[jamesr, 2013/05/23 23:46:46]

these points are still in Window coordinates, right? if you're losing the
coordinate space in the function name please at least document the space in the
comment

+    virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent) = 0;
+    virtual void moveCaretSelection(const WebPoint&) = 0;
 
     // Printing ------------------------------------------------------------
 
     // Reformats the WebFrame for printing. WebPrintParams specifies the printable
     // content size, paper size, printable area size, printer DPI and print
     // scaling option. If constrainToNode node is specified, then only the given node
     // is printed (for now only plugins are supported), instead of the entire frame.
     // Returns the number of pages that can be printed at the given
     // page size. The out param useBrowserOverlays specifies whether the browser
     // process should use its overlays (header, footer, margins etc) or whether
@@ skipping 180 matching lines @@
     // text form. This is used only by layout tests.
     virtual WebString layerTreeAsText(bool showDebugInfo = false) const = 0;
 
 protected:
     ~WebFrame() { }
 };
 
 } // namespace WebKit
 
 #endif