Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14990005: Remove ENTITY_REFERENCE_NODE (Closed)

Created:
7 years, 7 months ago by arv (Not doing code reviews)
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, jsbell+bindings_chromium.org, eae+blinkwatch, abarth_chromum.org, abarth-chromium, haraken, Nate Chapin
Visibility:
Public.

Description

Remove ENTITY_REFERENCE_NODE Based on eseidel's old WebKit patch at https://bugs.webkit.org/show_bug.cgi?id=91316 Removed document.createEntityReference and window.EntityReference from the JS-accessible DOM, as well as EntityReference, Document::createEntityReference and Node::ENTITY_REFERNECE_NODE from all core and all WebKit API layers. This is to match DOM4 http://www.w3.org/TR/dom/ and Mozilla, which removed these interfaces. This is covered by a zillion w3c tests. All of which now fail due to these missing interfaces. BUG=226628 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149983

Patch Set 1 #

Patch Set 2 : Now with updated tests #

Patch Set 3 : Remove some empty lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -430 lines) Patch
M LayoutTests/dom/html/level1/core/documentinvalidcharacterexceptioncreateentref-expected.txt View 1 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/dom/html/level1/core/documentinvalidcharacterexceptioncreateentref1-expected.txt View 1 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrgetvalue2-expected.txt View 1 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_nodevalue03-expected.txt View 1 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/documentinvalidcharacterexceptioncreateentref-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/documentinvalidcharacterexceptioncreateentref1-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrgetvalue2-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_nodevalue03-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode06-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode16-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentrenamenode27-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition26-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition27-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition28-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition29-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodegettextcontent17-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodeinsertbefore11-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodeinsertbefore15-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/noderemovechild12-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/noderemovechild13-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/noderemovechild14-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/noderemovechild15-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild18-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild19-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild22-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild23-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild30-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild33-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild34-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild35-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild36-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild37-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent10-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent11-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent12-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/textreplacewholetext06-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/textreplacewholetext07-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/textreplacewholetext08-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/EntityReference/readonly-exceptions.html View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/EntityReference/readonly-exceptions-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/EntityReference/script-tests/TEMPLATE.html View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/EntityReference/script-tests/readonly-exceptions.js View 1 1 chunk +0 lines, -31 lines 0 comments Download
M LayoutTests/fast/dom/Node/initial-values-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/Node/script-tests/initial-values.js View 1 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-properties.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/dom-constructors.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/dom-constructors-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/wrapper-classes.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/wrapper-classes-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt View 1 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/public/WebNode.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/WebKit/chromium/src/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8NodeCustom.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/dom/Attr.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Attr.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/dom/Document.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 7 chunks +0 lines, -24 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentFragment.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/dom/EntityReference.h View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/core/dom/EntityReference.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/core/dom/EntityReference.idl View 1 chunk +0 lines, -22 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 7 chunks +0 lines, -19 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 11 chunks +0 lines, -45 lines 0 comments Download
M Source/core/dom/ShadowRoot.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Text.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XPathUtil.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
arv (Not doing code reviews)
7 years, 7 months ago (2013-05-08 20:42:10 UTC) #1
adamk
lgtm! Thanks for doing this, I was about to start on the same change.
7 years, 7 months ago (2013-05-08 20:48:59 UTC) #2
esprehn
On 2013/05/08 20:48:59, adamk wrote: > lgtm! Thanks for doing this, I was about to ...
7 years, 7 months ago (2013-05-08 20:56:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14990005/4001
7 years, 7 months ago (2013-05-08 21:04:43 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_bare_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_bare_presubmit&number=678
7 years, 7 months ago (2013-05-08 21:12:09 UTC) #5
abarth-chromium
LGTM
7 years, 7 months ago (2013-05-08 21:21:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14990005/4001
7 years, 7 months ago (2013-05-08 21:21:42 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 22:02:17 UTC) #8
Message was sent while issue was closed. 
Change committed as 149983

Powered by Google App Engine
This is Rietveld 408576698