Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: Source/core/dom/Node.h

Issue 14990005: Remove ENTITY_REFERENCE_NODE (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove some empty lines Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/EntityReference.idl ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Node.h
diff --git a/Source/core/dom/Node.h b/Source/core/dom/Node.h
index b1c117d9b4f32fec930d7af891640a83cc8962e9..b919d19a5baae2942360d6ba4a9163d58c4faf3b 100644
--- a/Source/core/dom/Node.h
+++ b/Source/core/dom/Node.h
@@ -127,7 +127,6 @@ public:
ATTRIBUTE_NODE = 2,
TEXT_NODE = 3,
CDATA_SECTION_NODE = 4,
- ENTITY_REFERENCE_NODE = 5,
ENTITY_NODE = 6,
PROCESSING_INSTRUCTION_NODE = 7,
COMMENT_NODE = 8,
@@ -137,6 +136,15 @@ public:
NOTATION_NODE = 12,
XPATH_NAMESPACE_NODE = 13,
};
+
+ // EntityReference nodes are deprecated and impossible to create in WebKit.
+ // We want Node.ENTITY_REFERNCE_NODE to exist in JS and this enum, makes the bindings
+ // generation not complain about ENTITY_REFERENCE_NODE being missing from the implementation
+ // while not requiring all switch(NodeType) blocks to include this deprecated constant.
+ enum DeprecatedNodeType {
+ ENTITY_REFERENCE_NODE = 5
+ };
+
enum DocumentPosition {
DOCUMENT_POSITION_EQUIVALENT = 0x00,
DOCUMENT_POSITION_DISCONNECTED = 0x01,
@@ -474,7 +482,6 @@ public:
bool isInShadowTree() const { return getFlag(IsInShadowTreeFlag); }
bool isInTreeScope() const { return getFlag(static_cast<NodeFlags>(InDocumentFlag | IsInShadowTreeFlag)); }
- bool isReadOnlyNode() const { return nodeType() == ENTITY_REFERENCE_NODE; }
bool isDocumentTypeNode() const { return nodeType() == DOCUMENT_TYPE_NODE; }
virtual bool childTypeAllowed(NodeType) const { return false; }
unsigned childNodeCount() const;
« no previous file with comments | « Source/core/dom/EntityReference.idl ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698