Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: Source/core/dom/Attr.cpp

Issue 14990005: Remove ENTITY_REFERENCE_NODE (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove some empty lines Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Attr.h ('k') | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Attr.cpp
diff --git a/Source/core/dom/Attr.cpp b/Source/core/dom/Attr.cpp
index b71a1e264dca535d81430f75caf30f5ad0d65874..4751272a4a9a07c3c376712033c476bba916a280 100644
--- a/Source/core/dom/Attr.cpp
+++ b/Source/core/dom/Attr.cpp
@@ -151,13 +151,7 @@ PassRefPtr<Node> Attr::cloneNode(bool /*deep*/)
// DOM Section 1.1.1
bool Attr::childTypeAllowed(NodeType type) const
{
- switch (type) {
- case TEXT_NODE:
- case ENTITY_REFERENCE_NODE:
- return true;
- default:
- return false;
- }
+ return TEXT_NODE == type;
}
void Attr::childrenChanged(bool, Node*, Node*, int)
@@ -167,8 +161,6 @@ void Attr::childrenChanged(bool, Node*, Node*, int)
invalidateNodeListCachesInAncestors(&qualifiedName(), m_element);
- // FIXME: We should include entity references in the value
-
StringBuilder valueBuilder;
for (Node *n = firstChild(); n; n = n->nextSibling()) {
if (n->isTextNode())
« no previous file with comments | « Source/core/dom/Attr.h ('k') | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698