Issue 14912009: Support getEntryId for entries passed to apps as launch data.

Issue 14912009: Support getEntryId for entries passed to apps as launch data. (Closed)

Created:
7 years, 7 months ago by Sam McNally

Modified:
7 years, 7 months ago

Reviewers:
benwells, koz (OOO until 15th September), Matt Giuca

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Support getEntryId for entries passed to apps as launch data. Previously, chrome.fileSystem.getEntryId only supported entries returned by chrome.fileSystem.chooseEntry. This adds support for entries passed to apps in launchData for chrome.app.runtime.onLaunched events. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199693

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -37 lines)			Patch
M	chrome/browser/extensions/api/app_runtime/app_runtime_api.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/app_runtime/app_runtime_api.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/platform_app_launcher.cc	View	2 chunks	+7 lines, -26 lines	0 comments	Download
M	chrome/renderer/resources/extensions/app_runtime_custom_bindings.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_application_octet_stream/manifest.json	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_application_octet_stream/test.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file/manifest.json	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file/test.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file_by_extension/manifest.json	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file_by_extension/test.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file_by_extension_and_type/manifest.json	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file_by_extension_and_type/test.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file_with_any_extension/manifest.json	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file_with_any_extension/test.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file_with_no_extension/manifest.json	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file_with_no_extension/test.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/14912009/1

7 years, 7 months ago (2013-05-13 06:25:56 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=126851

7 years, 7 months ago (2013-05-13 07:18:15 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/14912009/1

7 years, 7 months ago (2013-05-13 07:25:55 UTC) #5

Message was sent while issue was closed.

Change committed as 199693

Expand Messages | Collapse Messages