chrome/renderer/resources/extensions/app_runtime_custom_bindings.js - Issue 14912009: Support getEntryId for entries passed to apps as launch data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/app_runtime_custom_bindings.js

Issue 14912009: Support getEntryId for entries passed to apps as launch data. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/platform_app_launcher.cc ('k') | chrome/test/data/extensions/platform_apps/launch_application_octet_stream/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/app_runtime_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/app_runtime_custom_bindings.js b/chrome/renderer/resources/extensions/app_runtime_custom_bindings.js

index 0f3a0f784daa5cc6874c6d2ae5c3b2a72a5fb9d7..a490c02677552bfac596483464b2968bffd2e4ba 100644

--- a/chrome/renderer/resources/extensions/app_runtime_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/app_runtime_custom_bindings.js

@@ -74,6 +74,7 @@ chromeHidden.Event.registerArgumentMassager('app.runtime.onLaunched',

forEach(launchData.items, function(i, item) {

var fs = GetIsolatedFileSystem(item.fileSystemId);

fs.root.getFile(item.baseName, {}, function(fileEntry) {

+ entryIdManager.registerEntry(item.entryId, fileEntry);

itemLoaded(null, { entry: fileEntry, type: item.mimeType });

}, function(fileError) {

itemLoaded(fileError);