Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.h - Issue 14892005: [CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.h

Issue 14892005: [CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: reverted LineSegment logicalLeft,Right type change Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.h

diff --git a/Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.h b/Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.h

index 378c88d922c51e7fa5334d774e04407afccef4b9..07296c73b6c23eb5fc4cd9d4c81470546e7f596f 100644

--- a/Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.h

+++ b/Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.h

@@ -50,7 +50,7 @@ public:

static bool isEnabledFor(const RenderBox*);

protected:

- virtual FloatRect computedShapeLogicalBoundingBox() const OVERRIDE { return computedShape()->shapeMarginLogicalBoundingBox(); }

+ virtual LayoutRect computedShapeLogicalBoundingBox() const OVERRIDE { return computedShape()->shapeMarginLogicalBoundingBox(); }

private:

ExclusionShapeOutsideInfo(const RenderBox* renderer) : ExclusionShapeInfo<RenderBox, &RenderStyle::shapeOutside, &ExclusionShape::getExcludedIntervals>(renderer) { }

« no previous file with comments | « Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp ('k') | no next file » | no next file with comments »