Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp - Issue 14892005: [CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp

Issue 14892005: [CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: reverted LineSegment logicalLeft,Right type change Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/exclusions/ExclusionShapeInsideInfo.h ('k') | Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp

diff --git a/Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp b/Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp

index f20265f2c0f52f73112d69eb728e88c82188a099..9f681d598ea4634e25b794b52dc19e6a75276bcc 100644

--- a/Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp

+++ b/Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp

@@ -53,9 +53,8 @@ bool ExclusionShapeInsideInfo::adjustLogicalLineTop(float minSegmentWidth)

if (!shape || m_lineHeight <= 0 || logicalLineTop() > shapeLogicalBottom())

return false;

- float floatNewLineTop;

- if (shape->firstIncludedIntervalLogicalTop(m_shapeLineTop, FloatSize(minSegmentWidth, m_lineHeight), floatNewLineTop)) {

- LayoutUnit newLineTop = floatLogicalTopToLayoutUnit(floatNewLineTop);

+ LayoutUnit newLineTop;

+ if (shape->firstIncludedIntervalLogicalTop(m_shapeLineTop, LayoutSize(minSegmentWidth, m_lineHeight), newLineTop)) {

if (newLineTop > m_shapeLineTop) {

m_shapeLineTop = newLineTop;

return true;