Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Side by Side Diff: Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.h

Issue 14892005: [CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: reverted LineSegment logicalLeft,Right type change Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 LayoutUnit leftSegmentShapeBoundingBoxDelta() const { return m_leftSegmentSh apeBoundingBoxDelta; } 44 LayoutUnit leftSegmentShapeBoundingBoxDelta() const { return m_leftSegmentSh apeBoundingBoxDelta; }
45 LayoutUnit rightSegmentShapeBoundingBoxDelta() const { return m_rightSegment ShapeBoundingBoxDelta; } 45 LayoutUnit rightSegmentShapeBoundingBoxDelta() const { return m_rightSegment ShapeBoundingBoxDelta; }
46 46
47 virtual bool computeSegmentsForLine(LayoutUnit lineTop, LayoutUnit lineHeigh t) OVERRIDE; 47 virtual bool computeSegmentsForLine(LayoutUnit lineTop, LayoutUnit lineHeigh t) OVERRIDE;
48 48
49 static PassOwnPtr<ExclusionShapeOutsideInfo> createInfo(const RenderBox* ren derer) { return adoptPtr(new ExclusionShapeOutsideInfo(renderer)); } 49 static PassOwnPtr<ExclusionShapeOutsideInfo> createInfo(const RenderBox* ren derer) { return adoptPtr(new ExclusionShapeOutsideInfo(renderer)); }
50 static bool isEnabledFor(const RenderBox*); 50 static bool isEnabledFor(const RenderBox*);
51 51
52 protected: 52 protected:
53 virtual FloatRect computedShapeLogicalBoundingBox() const OVERRIDE { return computedShape()->shapeMarginLogicalBoundingBox(); } 53 virtual LayoutRect computedShapeLogicalBoundingBox() const OVERRIDE { return computedShape()->shapeMarginLogicalBoundingBox(); }
54 54
55 private: 55 private:
56 ExclusionShapeOutsideInfo(const RenderBox* renderer) : ExclusionShapeInfo<Re nderBox, &RenderStyle::shapeOutside, &ExclusionShape::getExcludedIntervals>(rend erer) { } 56 ExclusionShapeOutsideInfo(const RenderBox* renderer) : ExclusionShapeInfo<Re nderBox, &RenderStyle::shapeOutside, &ExclusionShape::getExcludedIntervals>(rend erer) { }
57 57
58 LayoutUnit m_leftSegmentShapeBoundingBoxDelta; 58 LayoutUnit m_leftSegmentShapeBoundingBoxDelta;
59 LayoutUnit m_rightSegmentShapeBoundingBoxDelta; 59 LayoutUnit m_rightSegmentShapeBoundingBoxDelta;
60 LayoutUnit m_lineTop; 60 LayoutUnit m_lineTop;
61 }; 61 };
62 62
63 } 63 }
64 #endif 64 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698