Re-apply https://codereview.chromium.org/14636002/, but this time avoid creating TypeMask with dyna…

Re-apply https://codereview.chromium.org/14636002/, but this time avoid creating TypeMask with dynamic.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22307

[ngeoffray, 2013-05-02 09:11:46]

Patchset 1 contains the original patch.
Patchset 2 contains the fix (and merges with trunk)

I also found a bug in TypeMask.willHit in case a method is declared abstract in
a class, but its superclass has an implementation for it. I added a testcase.

[kasperl, 2013-05-02 09:14:23]

LGTM.

https://codereview.chromium.org/14751009/diff/6001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/type_mask.dart (right):

https://codereview.chromium.org/14751009/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:569: return
hasConcreteMatch(
I'd prefer pulling out the enclosing class in a local variable to improve
formatting.

[ngeoffray, 2013-05-02 09:20:51]

Thanks Kasper

@Paul: With this change, using isSubtype, isSubclass and base on a TypeMask will
give you static warnings. I have changed the code of TypesTask.best to take
untyped parameters for now, but we should find out a better way of computing a
best result, not based on isSubclass and isSubtype. I think we can take the
containedClasses of both TypeMask and take the one that has the smaller set.
WDYT?

https://codereview.chromium.org/14751009/diff/6001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/type_mask.dart (right):

https://codereview.chromium.org/14751009/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:569: return
hasConcreteMatch(
On 2013/05/02 09:14:23, kasperl wrote:
> I'd prefer pulling out the enclosing class in a local variable to improve
> formatting.

Done.

[ngeoffray, 2013-05-02 09:44:11]

Committed patchset #4 manually as r22307 (presubmit successful).