sdk/lib/_internal/compiler/implementation/types/types.dart - Issue 14751009: Re-apply https://codereview.chromium.org/14636002/, but this time avoid creating TypeMask with dyna…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/types.dart

Issue 14751009: Re-apply https://codereview.chromium.org/14636002/, but this time avoid creating TypeMask with dyna… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/types/type_mask.dart ('k') | sdk/lib/_internal/compiler/implementation/universe/universe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/types/types.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/types/types.dart (revision 22306)

+++ sdk/lib/_internal/compiler/implementation/types/types.dart (working copy)

@@ -89,7 +89,7 @@

* exactness, subclassing, subtyping and nullability. The [element] parameter

* is for debugging purposes only and can be omitted.

- TypeMask best(TypeMask type1, TypeMask type2, [element]) {

+ TypeMask best(var type1, var type2, [element]) {

final result = _best(type1, type2);

similar() {

if (type1 == null) return type2 == null;

@@ -103,7 +103,7 @@

}

/// Helper method for [best].

- TypeMask _best(TypeMask type1, TypeMask type2) {

+ TypeMask _best(var type1, var type2) {

if (type1 == null) return type2;

if (type2 == null) return type1;

if (type1.isExact) {