Fix many (but not all[1]) depot_tools tests on Windows.

Fix many (but not all[1]) depot_tools tests on Windows.

[1] *scm_test.py are deeply broken, svnadmin is missing for svn_bin\.
And the git test are failing at shutdown.

Also Fix SvnCheckout.testMove flakiness.

TBR=ilevy@chromium.org,szager@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=198900

[M-A Ruel, 2013-05-08 14:43:52]

Please run tests on Windows when working on depot_tools. It's necessary as long
as we still release Google Chrome on Windows.

Preferably, the presubmit checks should be run on either dedicated TS builders
or on Swarm slaves.

https://codereview.chromium.org/14729012/diff/1/tests/gclient_scm_test.py
File tests/gclient_scm_test.py (right):

https://codereview.chromium.org/14729012/diff/1/tests/gclient_scm_test.py#new...
tests/gclient_scm_test.py:1067: self.root_dir = '/tmp' if sys.platform !=
'win32' else 't:\\tmp'
/tmp would get badly normalized.

https://codereview.chromium.org/14729012/diff/1/tests/subprocess2_test.py
File tests/subprocess2_test.py (right):

https://codereview.chromium.org/14729012/diff/1/tests/subprocess2_test.py#new...
tests/subprocess2_test.py:334: p1 = subprocess.Popen(cmd,
stderr=subprocess.PIPE, shell=False)
shell=True and timeout cannot be mixed.

[commit-bot: I haz the power, 2013-05-08 14:45:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/14729012/5001

[commit-bot: I haz the power, 2013-05-08 14:47:19]

Presubmit check for 14729012-5001 failed and returned exit status 1.

INFO:root:Found 3 file(s).
INFO:PRESUBMIT:Running pylint on 61 files
Running presubmit commit checks ...
Running /b/commit-queue/workdir/tools/depot_tools/PRESUBMIT.py
Running tests/gclient_utils_test.py
Running tests/watchlists_unittest.py
Running tests/checkout_test.py
Running tests/scm_unittest.py
Running tests/gcl_unittest.py
Running tests/patch_test.py
Running tests/fix_encoding_test.py
Running tests/presubmit_unittest.py
Running tests/trychange_unittest.py
Running tests/rietveld_test.py
Running tests/owners_unittest.py
Running tests/breakpad_unittest.py
Running tests/gclient_test.py
Running tests/gclient_smoketest.py
Running tests/subprocess2_test.py
Running tests/git_cl_test.py
Running tests/gclient_scm_test.py
INFO:root:/usr/bin/python /b/google_appengine/dev_appserver.py . --port 8080
--storage /tmp/rietveld_testsulBv0 --clear_search_indexes
--skip_sdk_update_check
Setting up test upstream git repo...
Setting up test git repo...
TESTING: uploading to bogus server
 test | 1 +
 1 file changed, 1 insertion(+)
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit upload checks ...

Presubmit checks passed.
Upload server: http://bogus.example.com:80 (change with -s/--server)
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies

Got exception while uploading -- saving description to
/home/chrome-bot/.git_cl_description_backup

TESTING: description was backed up
PASS
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1506 --:--:-- --:--:-- --:--:--  1540
TESTING: Base URL contains branch name
TESTING: git-cl push ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5629499534213120'
Closing issue (you may be prompted for your codereview password)...
TESTING: committed code has proper description
TESTING: issue no longer has a branch
TESTING: upstream repo has our commit
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
The --set-upstream flag is deprecated and will be removed. Consider using
--track or --set-upstream-to
Branch feature_branch set up to track local ref refs/remotes/trunk.
TESTING: Guessing upstream branch for refs/remotes/trunk
The --set-upstream flag is deprecated and will be removed. Consider using
--track or --set-upstream-to
Branch feature_branch set up to track local ref refs/remotes/some_branch.
TESTING: Guessing upstream branch for refs/remotes/some_branch
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl dcommits ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'test\n\nBUG=\n\nReview URL:
http://localhost:8080/5910974510923776'
Closing issue (you may be prompted for your codereview password)...
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

Switched to branch 'master'
Deleted branch abandoned (was f89e82c).
TESTING: git-cl status dropped abandoned branch
PASS
Setting up test SVN repo...
Setting up test remote git-svn-submodule repo...
Switched to branch 'master'
TESTING: dcommitted code
Switched to branch 'git-cl-cherry-pick'
Using 50% similarity for rename/copy detection. Override with --similarity.
Description: 'dcommit'
TESTING: svn got new revision
TESTING: svn diff is correct
TESTING: git svn fetch gets new svn revision
PASS
Setting up test upstream git repo...
Setting up test git repo...
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload hook fails
Command "git --no-pager config rietveld.server" failed.
Could not find settings file. You must configure your review setup by running
"git cl config".
TESTING: git-cl dcommit hook fails
Command "git --no-pager config rietveld.server" failed.
Could not find settings file. You must configure your review setup by running
"git cl config".
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
Using 50% similarity for rename/copy detection. Override with --similarity.
Description: 'dcommit'
TESTING: post-cl-dcommit hook executed
PASS
Setting up test upstream git repo...
Setting up test git repo...
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: description shouldn't contain unrelated commits
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl status now knows the issue
TESTING: git cl patch 5981343255101440
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1745 --:--:-- --:--:-- --:--:--  1790
TESTING: git-cl dcommits ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5840605766746112'
Closing issue (you may be prompted for your codereview password)...
TESTING: dcommitted code has proper description
TESTING: issue no longer has a branch
TESTING: upstream svn has our commit
PASS
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
tests/checkout_test.py failed
testAll (__main__.RawCheckout) ... ok
testException (__main__.RawCheckout) ... ok
testMove (__main__.RawCheckout) ... ok
testPrepare (__main__.RawCheckout) ... ok
testProcess (__main__.RawCheckout) ... ok
testAll (__main__.ReadOnlyCheckout) ... ok
testException (__main__.ReadOnlyCheckout) ... ok
testMove (__main__.ReadOnlyCheckout) ... ok
testPrepare (__main__.ReadOnlyCheckout) ... ok
testProcess (__main__.ReadOnlyCheckout) ... ok
testAll (__main__.SvnCheckout) ... ok
testAutoProps (__main__.SvnCheckout) ... ok
testException (__main__.SvnCheckout) ... ok
testMove (__main__.SvnCheckout) ... FAIL
testPrepare (__main__.SvnCheckout) ... ok
testProcess (__main__.SvnCheckout) ... ok
testSvnProps (__main__.SvnCheckout) ... ok
testWithRevPropsSupport (__main__.SvnCheckout) ... ok
testWithRevPropsSupportNotCommitBot (__main__.SvnCheckout) ... ok

======================================================================
FAIL: testMove (__main__.SvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 407, in testMove
    self.assertEquals(expected, out)
AssertionError: 'A  +    chromeos/views/webui_menu_widget.h\nD      
chromeos/views/DOMui_menu_widget.h\n' != 'D      
chromeos/views/DOMui_menu_widget.h\nA  +   
chromeos/views/webui_menu_widget.h\n'

----------------------------------------------------------------------
Ran 19 tests in 10.882s

FAILED (failures=1)


Presubmit checks took 87.8s to calculate.

[commit-bot: I haz the power, 2013-05-08 14:56:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/14729012/3003

[commit-bot: I haz the power, 2013-05-08 14:58:35]

Change committed as 198900