Fix many (but not all[1]) depot_tools tests on Windows.

tests/subprocess2_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for subprocess2.py."""
 
 import logging
 import optparse
 import os
 import sys
 import time
 import unittest
 
 try:
-  import fcntl
+  import fcntl  # pylint: disable=F0401
 except ImportError:
   fcntl = None
 
 sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 import subprocess
 import subprocess2
 
 from testing_support import auto_stub
 
@@ skipping 295 matching lines @@
     def fn(c, e, un, subp):
       # stderr output into stdout but stdout is not piped.
       proc = subp.Popen(
           e + ['--stderr'], stderr=STDOUT, universal_newlines=un)
       res = proc.communicate(), proc.returncode
       self._check_res(res, None, None, 0)
     self._run_test(fn)
 
   def test_stderr(self):
     cmd = ['expr', '1', '/', '0']
-    p1 = subprocess.Popen(cmd, stderr=subprocess.PIPE)
-    p2 = subprocess2.Popen(cmd, stderr=subprocess.PIPE)
+    if sys.platform == 'win32':
+      cmd = ['cmd.exe', '/c', 'exit', '1']
+    p1 = subprocess.Popen(cmd, stderr=subprocess.PIPE, shell=False)
+    p2 = subprocess2.Popen(cmd, stderr=subprocess.PIPE, shell=False)
     r1 = p1.communicate()
     r2 = p2.communicate(timeout=100)
     self.assertEquals(r1, r2)
 
 
 class S2Test(BaseTestCase):
   # Tests that can only run in subprocess2, e.g. new functionalities.
   # In particular, subprocess2.communicate() doesn't exist in subprocess.
   def _run_test(self, function):
     """Runs tests in 6 combinations:
@@ skipping 80 matching lines @@
     self._check_res(res, None, None, 0)
 
   def test_stdin_void_stdout_timeout(self):
     # Make sure a mix of VOID, PIPE and timeout works.
     def fn(c, e, un):
       res = subprocess2.communicate(
           e + ['--stdout', '--read'],
           stdin=VOID,
           stdout=PIPE,
           timeout=10,
-          universal_newlines=un)
+          universal_newlines=un,
+          shell=False)
       self._check_res(res, c('A\nBB\nCCC\n'), None, 0)
     self._run_test(fn)
 
   def test_stdout_void(self):
     def fn(c, e, un):
       res = subprocess2.communicate(
           e + ['--stdout', '--stderr'],
           stdout=VOID,
           stderr=PIPE,
           universal_newlines=un)
@@ skipping 124 matching lines @@
     self.assertEquals(128*1024, len(''.join(stdout)))
     self._check_res(res, None, None, 0)
 
   def test_tee_large_stdin(self):
     stdout = []
     # Write 128kb.
     stdin = '0123456789abcdef' * (8*1024)
     res = subprocess2.communicate(
         self.exe + ['--large', '--read'], stdin=stdin, stdout=stdout.append)
     self.assertEquals(128*1024, len(''.join(stdout)))
-    self._check_res(res, None, None, 0)
+    # Windows return code is > 8 bits.
+    returncode = len(stdin) if sys.platform == 'win32' else 0
+    self._check_res(res, None, None, returncode)
 
   def test_tee_cb_throw(self):
     # Having a callback throwing up should not cause side-effects. It's a bit
     # hard to measure.
     class Blow(Exception):
       pass
     def blow(_):
       raise Blow()
     proc = subprocess2.Popen(self.exe + ['--stdout'], stdout=blow)
     try:
@@ skipping 81 matching lines @@
   return options.return_value
 
 
 if __name__ == '__main__':
   logging.basicConfig(level=
       [logging.WARNING, logging.INFO, logging.DEBUG][
         min(2, sys.argv.count('-v'))])
   if len(sys.argv) > 1 and sys.argv[1] == '--child':
     sys.exit(child_main(sys.argv[2:]))
   unittest.main()