Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1469123003: ServiceWorker: Ensure that ServiceWorkerDispatcher always adopts passed handle references (2) (Closed)

Created:
5 years ago by nhiroki
Modified:
5 years ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Ensure that ServiceWorkerDispatcher always adopts passed handle references (2) Some message handlers on ServiceWorkerDispatcher receive registration/worker handle references sent from the browser process. Those should surely be adopted by the dispatcher but not in some early-return cases. This means that handles in the browser process are leaked until renderer shutdown. This CL ensures that the dispatcher always adopts passed handle references at the beginning of message handlers. Previous CL: https://codereview.chromium.org/1454963003 BUG=557655 Committed: https://crrev.com/7078fc1b5f057ee0f7a4fee34718830eb5e1204a Cr-Commit-Position: refs/heads/master@{#361593}

Patch Set 1 : #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -101 lines) Patch
M content/child/service_worker/service_worker_dispatcher.h View 1 chunk +3 lines, -10 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 10 chunks +44 lines, -55 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher_unittest.cc View 1 8 chunks +73 lines, -34 lines 0 comments Download
M content/child/service_worker/service_worker_handle_reference.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
nhiroki
ptal, thanks!
5 years ago (2015-11-25 04:15:41 UTC) #5
falken
LGTM
5 years ago (2015-11-25 04:28:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469123003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469123003/80001
5 years ago (2015-11-25 05:04:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years ago (2015-11-25 06:37:53 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 06:38:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7078fc1b5f057ee0f7a4fee34718830eb5e1204a
Cr-Commit-Position: refs/heads/master@{#361593}

Powered by Google App Engine
This is Rietveld 408576698