Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: content/child/service_worker/service_worker_dispatcher.h

Issue 1469123003: ServiceWorker: Ensure that ServiceWorkerDispatcher always adopts passed handle references (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_dispatcher.h
diff --git a/content/child/service_worker/service_worker_dispatcher.h b/content/child/service_worker/service_worker_dispatcher.h
index 1c6b529b06fde6a8bf23485948760e6f2568e156..08da5802c2ee52874139b9c8491506f2af0e9e49 100644
--- a/content/child/service_worker/service_worker_dispatcher.h
+++ b/content/child/service_worker/service_worker_dispatcher.h
@@ -113,17 +113,10 @@ class CONTENT_EXPORT ServiceWorkerDispatcher : public WorkerThread::Observer {
blink::WebServiceWorkerProviderClient* client);
void RemoveProviderClient(int provider_id);
- // Returns the existing service worker or a newly created one. When a new one
- // is created, increments an interprocess reference to the service worker via
- // ServiceWorkerHandleReference. Returns nullptr if the given info is invalid.
+ // Returns the existing service worker or a newly created one with the given
+ // handle reference. Returns nullptr if the given reference is invalid.
scoped_refptr<WebServiceWorkerImpl> GetOrCreateServiceWorker(
- const ServiceWorkerObjectInfo& info);
-
- // Returns the existing service worker or a newly created one. Always adopts
- // an interprocess reference to the service worker via
- // ServiceWorkerHandleReference. Returns nullptr if the given info is invalid.
- scoped_refptr<WebServiceWorkerImpl> GetOrAdoptServiceWorker(
- const ServiceWorkerObjectInfo& info);
+ scoped_ptr<ServiceWorkerHandleReference> handle_ref);
// Returns the existing registration or a newly created one. When a new one is
// created, increments interprocess references to the registration and its
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698