content/child/service_worker/service_worker_handle_reference.h - Issue 1469123003: ServiceWorker: Ensure that ServiceWorkerDispatcher always adopts passed handle references (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_handle_reference.h

Issue 1469123003: ServiceWorker: Ensure that ServiceWorkerDispatcher always adopts passed handle references (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher_unittest.cc ('k') | content/child/service_worker/web_service_worker_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_handle_reference.h

diff --git a/content/child/service_worker/service_worker_handle_reference.h b/content/child/service_worker/service_worker_handle_reference.h

index 064f5414698c4329d44b72773063cf35f9be1a13..81305cd0781f7ef8d26e0be7690112269a826ab2 100644

--- a/content/child/service_worker/service_worker_handle_reference.h

+++ b/content/child/service_worker/service_worker_handle_reference.h

@@ -7,6 +7,7 @@

#include "base/memory/ref_counted.h"

#include "base/memory/scoped_ptr.h"

+#include "content/common/content_export.h"

#include "content/common/service_worker/service_worker_types.h"

namespace content {

@@ -16,7 +17,7 @@ class ThreadSafeSender;

// Represents an interprocess reference to ServiceWorkerHandle managed in the

// browser process. The constructor and destructor sends a message to increment

// or decrement the reference count to the browser process.

-class ServiceWorkerHandleReference {

+class CONTENT_EXPORT ServiceWorkerHandleReference {

public:

// Creates a new ServiceWorkerHandleReference and increments ref-count.

static scoped_ptr<ServiceWorkerHandleReference> Create(