Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 14655010: Revert 198556 "Implement the rest of the audio API." (Closed)

Created:
7 years, 7 months ago by rkc
Modified:
7 years, 7 months ago
Reviewers:
rkc, Matt Perry
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 198556 "Implement the rest of the audio API." > Implement the rest of the audio API. > Picking up where https://codereview.chromium.org/13486004/ left off, implemented the setProperties and setActiveDevices calls; also fixed GetNodes to also return the volume of the devices. > > R=hshi@chromium.org, jennyz@chromium.org, mpcomplete@chromium.org > BUG=175798 > TEST=Wrote a test extension to set the volume on the active and inactive devices, to verify they were set correctly. Also wrote code to switch active devices to verify that the devices did switch. > > Review URL: https://codereview.chromium.org/14652027 TBR=rkc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -363 lines) Patch
M trunk/src/ash/system/chromeos/audio/tray_audio.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/ash/system/chromeos/audio/tray_audio.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h View 1 chunk +4 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.cc View 3 chunks +42 lines, -29 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/audio/audio_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/audio/audio_api.cc View 1 chunk +5 lines, -32 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/audio/audio_service.h View 2 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/audio/audio_service.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/audio/audio_service_chromeos.cc View 8 chunks +6 lines, -95 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/_permission_features.json View 1 chunk +4 lines, -14 lines 0 comments Download
M trunk/src/chromeos/audio/audio_devices_pref_handler.h View 1 chunk +8 lines, -10 lines 0 comments Download
M trunk/src/chromeos/audio/cras_audio_handler.h View 7 chunks +2 lines, -38 lines 0 comments Download
M trunk/src/chromeos/audio/cras_audio_handler.cc View 11 chunks +6 lines, -96 lines 0 comments Download
M trunk/src/chromeos/audio/cras_audio_switch_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chromeos/audio/cras_audio_switch_handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rkc
7 years, 7 months ago (2013-05-07 00:04:41 UTC) #1
rkc
Committed patchset #1 manually as r198568.
7 years, 7 months ago (2013-05-07 00:05:00 UTC) #2
Matt Perry
Could you check in a CL with just the _permission_features.json change today?
7 years, 7 months ago (2013-05-07 00:22:45 UTC) #3
rkc
On 2013/05/07 00:22:45, Matt Perry wrote: > Could you check in a CL with just ...
7 years, 7 months ago (2013-05-07 00:24:46 UTC) #4
Matt Perry
7 years, 7 months ago (2013-05-07 00:38:18 UTC) #5
Message was sent while issue was closed.
On 2013/05/07 00:24:46, Rahul Chaturvedi wrote:
> On 2013/05/07 00:22:45, Matt Perry wrote:
> > Could you check in a CL with just the _permission_features.json change
today?
> 
> I already have this fixed, I am just waiting for the VM to build so I can test
> it. It was a really trivial fix.

OK, as long as the _permission_features change makes it in before the branch
point.

Powered by Google App Engine
This is Rietveld 408576698