Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: trunk/src/chrome/browser/extensions/api/audio/audio_api.cc

Issue 14655010: Revert 198556 "Implement the rest of the audio API." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/api/audio/audio_api.cc
===================================================================
--- trunk/src/chrome/browser/extensions/api/audio/audio_api.cc (revision 198567)
+++ trunk/src/chrome/browser/extensions/api/audio/audio_api.cc (working copy)
@@ -60,45 +60,18 @@
if (success)
results_ = api::audio::GetInfo::Results::Create(output_info, input_info);
else
- SetError("Error occurred when querying audio device information.");
+ SetError("Error occured when querying audio device information.");
SendResponse(success);
}
bool AudioSetActiveDevicesFunction::RunImpl() {
- scoped_ptr<api::audio::SetActiveDevices::Params> params(
- api::audio::SetActiveDevices::Params::Create(*args_));
- EXTENSION_FUNCTION_VALIDATE(params.get());
-
- AudioService* service =
- AudioAPI::GetFactoryInstance()->GetForProfile(profile())->GetService();
- DCHECK(service);
-
- service->SetActiveDevices(params->ids);
- return true;
+ // TODO: implement this.
+ return false;
}
bool AudioSetPropertiesFunction::RunImpl() {
- scoped_ptr<api::audio::SetProperties::Params> params(
- api::audio::SetProperties::Params::Create(*args_));
- EXTENSION_FUNCTION_VALIDATE(params.get());
-
- AudioService* service =
- AudioAPI::GetFactoryInstance()->GetForProfile(profile())->GetService();
- DCHECK(service);
-
- int volume_value = params->properties.volume.get() ?
- *params->properties.volume : -1;
-
- int gain_value = params->properties.gain.get() ?
- *params->properties.gain : -1;
-
- if (!service->SetDeviceProperties(params->id,
- params->properties.is_muted,
- volume_value,
- gain_value))
- return false;
- else
- return true;
+ // TODO: implement this.
+ return false;
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698