chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc - Issue 14651017: Move RuntimeData and related permissions out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_permissions

Patch Set: Latest master Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_helpers.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

index a77de3b5352a953bf389457d50272d145497499a..56e38fd0698d7105cf50d3c473f49f377037e209 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

@@ -16,6 +16,7 @@

#include "chrome/browser/extensions/api/web_request/web_request_permissions.h"

#include "chrome/browser/extensions/extension_system.h"

#include "chrome/common/extensions/extension.h"

+#include "chrome/common/extensions/permissions/permissions_data.h"

#include "extensions/common/error_utils.h"

#include "net/url_request/url_request.h"

@@ -339,7 +340,7 @@ bool WebRequestRulesRegistry::HostPermissionsChecker(

const Extension* extension,

const WebRequestActionSet* actions,

std::string* error) {

- if (extension->HasEffectiveAccessToAllHosts())

+ if (PermissionsData::HasEffectiveAccessToAllHosts(extension))

return true;

// Without the permission for all URLs, actions with the STRATEGY_DEFAULT