Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed)

Created:
7 years, 7 months ago by Devlin
Modified:
7 years, 7 months ago
CC:
chromium-reviews, vsevik, benjhayden+dwatch_chromium.org, kkania, yurys, Aaron Boodman, robertshield, chromium-apps-reviews_chromium.org, pfeldman
Base URL:
http://git.chromium.org/chromium/src.git@dc_unref_permissions
Visibility:
Public.

Description

Move RuntimeData and related permissions out of Extension class BUG=159265 TBR=ben@chromium.org (gypi) TBR=darin@chromium.org (automation) TBR=vandebo@chromium.org (media_galleries) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200787

Patch Set 1 : #

Total comments: 10

Patch Set 2 : Yoyo's requests #

Patch Set 3 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+756 lines, -1483 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/active_tab_unittest.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_helpers.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_api.cc View 9 chunks +26 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 5 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 5 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.h View 1 6 chunks +2 lines, -122 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 6 chunks +5 lines, -250 lines 0 comments Download
M chrome/common/extensions/extension_messages.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 10 chunks +25 lines, -635 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 10 chunks +22 lines, -10 lines 0 comments Download
M chrome/common/extensions/permissions/permissions_data.h View 3 chunks +126 lines, -10 lines 0 comments Download
M chrome/common/extensions/permissions/permissions_data.cc View 1 7 chunks +281 lines, -6 lines 0 comments Download
A + chrome/common/extensions/permissions/permissions_data_unittest.cc View 22 chunks +129 lines, -353 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.cc View 1 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
Yoyo - still working on testing this, but it should be mostly done. Please take ...
7 years, 7 months ago (2013-05-10 02:38:22 UTC) #1
Yoyo Zhou
https://chromiumcodereview.appspot.com/14651017/diff/8001/chrome/common/extensions/extension.h File chrome/common/extensions/extension.h (right): https://chromiumcodereview.appspot.com/14651017/diff/8001/chrome/common/extensions/extension.h#newcode250 chrome/common/extensions/extension.h:250: // Do Not Use: These methods have been moved ...
7 years, 7 months ago (2013-05-11 00:57:04 UTC) #2
Devlin
https://codereview.chromium.org/14651017/diff/8001/chrome/common/extensions/extension.h File chrome/common/extensions/extension.h (right): https://codereview.chromium.org/14651017/diff/8001/chrome/common/extensions/extension.h#newcode250 chrome/common/extensions/extension.h:250: // Do Not Use: These methods have been moved ...
7 years, 7 months ago (2013-05-13 22:44:23 UTC) #3
Yoyo Zhou
LGTM
7 years, 7 months ago (2013-05-15 18:26:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/14651017/30001
7 years, 7 months ago (2013-05-15 22:05:58 UTC) #5
vandebo (ex-Chrome)
media galleries LGTM
7 years, 7 months ago (2013-05-15 22:13:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=40439
7 years, 7 months ago (2013-05-16 01:32:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/14651017/76001
7 years, 7 months ago (2013-05-17 02:16:02 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 11:29:07 UTC) #9
Message was sent while issue was closed. 
Change committed as 200787

Powered by Google App Engine
This is Rietveld 408576698