chrome/browser/extensions/api/cookies/cookies_helpers.cc - Issue 14651017: Move RuntimeData and related permissions out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cookies/cookies_helpers.cc

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_permissions

Patch Set: Latest master Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_api.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cookies/cookies_helpers.cc

diff --git a/chrome/browser/extensions/api/cookies/cookies_helpers.cc b/chrome/browser/extensions/api/cookies/cookies_helpers.cc

index c61e7294f104b479105a9cb572ac9ada34e14dd3..f6f9c9303c98d7dbe63f3aea551b8ee797260089 100644

--- a/chrome/browser/extensions/api/cookies/cookies_helpers.cc

+++ b/chrome/browser/extensions/api/cookies/cookies_helpers.cc

@@ -21,6 +21,7 @@

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/extensions/api/cookies.h"

#include "chrome/common/extensions/extension.h"

+#include "chrome/common/extensions/permissions/permissions_data.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/web_contents.h"

#include "googleurl/src/gurl.h"

@@ -134,7 +135,7 @@ void AppendMatchingCookiesToVector(const net::CookieList& all_cookies,

// Ignore any cookie whose domain doesn't match the extension's

// host permissions.

GURL cookie_domain_url = GetURLFromCanonicalCookie(*it);

- if (!extension->HasHostPermission(cookie_domain_url))

+ if (!PermissionsData::HasHostPermission(extension, cookie_domain_url))

continue;

// Filter the cookie using the match filter.

cookies_helpers::MatchFilter filter(details);