Source/modules/webaudio/AudioNodeOutput.cpp - Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioNodeOutput.cpp

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Require use of Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/AudioNodeOutput.cpp

diff --git a/Source/modules/webaudio/AudioNodeOutput.cpp b/Source/modules/webaudio/AudioNodeOutput.cpp

index 0a1e5084f4d37c72e5dc4ad7bfd6bac51f660301..1eb96782ef1abf069da6f3f1a169f9fa1b7f3f4d 100644

--- a/Source/modules/webaudio/AudioNodeOutput.cpp

+++ b/Source/modules/webaudio/AudioNodeOutput.cpp

@@ -47,7 +47,7 @@ AudioNodeOutput::AudioNodeOutput(AudioNode* node, unsigned numberOfChannels)

{

ASSERT(numberOfChannels <= AudioContext::maxNumberOfChannels());

- m_internalBus = adoptRef(new AudioBus(numberOfChannels, AudioNode::ProcessingSizeInFrames));

+ m_internalBus = AudioBus::create(numberOfChannels, AudioNode::ProcessingSizeInFrames);

}

void AudioNodeOutput::setNumberOfChannels(unsigned numberOfChannels)

@@ -71,7 +71,7 @@ void AudioNodeOutput::updateInternalBus()

if (numberOfChannels() == m_internalBus->numberOfChannels())

return;

- m_internalBus = adoptRef(new AudioBus(numberOfChannels(), AudioNode::ProcessingSizeInFrames));

+ m_internalBus = AudioBus::create(numberOfChannels(), AudioNode::ProcessingSizeInFrames);

}

void AudioNodeOutput::updateRenderingState()

« no previous file with comments | « Source/modules/webaudio/AudioNodeInput.cpp ('k') | Source/modules/webaudio/AudioParam.cpp » ('j') | no next file with comments »