Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: Source/modules/webaudio/AudioNodeInput.cpp

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Require use of Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webaudio/AudioDestinationNode.h ('k') | Source/modules/webaudio/AudioNodeOutput.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioNodeInput.cpp
diff --git a/Source/modules/webaudio/AudioNodeInput.cpp b/Source/modules/webaudio/AudioNodeInput.cpp
index 6c36cfd4ebafdce38c915149647195ecf12fd5c8..12ecea4ecf6755a92827e24c1ced80aef0597bd3 100644
--- a/Source/modules/webaudio/AudioNodeInput.cpp
+++ b/Source/modules/webaudio/AudioNodeInput.cpp
@@ -42,7 +42,7 @@ AudioNodeInput::AudioNodeInput(AudioNode* node)
, m_node(node)
{
// Set to mono by default.
- m_internalSummingBus = adoptRef(new AudioBus(1, AudioNode::ProcessingSizeInFrames));
+ m_internalSummingBus = AudioBus::create(1, AudioNode::ProcessingSizeInFrames);
}
void AudioNodeInput::connect(AudioNodeOutput* output)
@@ -144,7 +144,7 @@ void AudioNodeInput::updateInternalBus()
if (numberOfInputChannels == m_internalSummingBus->numberOfChannels())
return;
- m_internalSummingBus = adoptRef(new AudioBus(numberOfInputChannels, AudioNode::ProcessingSizeInFrames));
+ m_internalSummingBus = AudioBus::create(numberOfInputChannels, AudioNode::ProcessingSizeInFrames);
}
unsigned AudioNodeInput::numberOfChannels() const
« no previous file with comments | « Source/modules/webaudio/AudioDestinationNode.h ('k') | Source/modules/webaudio/AudioNodeOutput.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698