Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1821)

Issue 145583014: A fix for the globals.h TODO in libplatform. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 10 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

A fix for the globals.h TODO in libplatform. The fix is simple, we make our version of globals.h called macros.h with the necessary macro used by libplatform files. BUG=v8:3015 TEST=builds R=jochen@chromium.org,bmeurer@chromium.org LOG=n

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : base/globals.h #

Patch Set 4 : fix header include guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -459 lines) Patch
M src/allocation.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/atomicops.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/base/globals.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/bignum.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/cached-powers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/conversions-inl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/date.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/diy-fp.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/globals.h View 1 2 1 chunk +0 lines, -422 lines 0 comments Download
M src/heap.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/libplatform/default-platform.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/libplatform/task-queue.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/libplatform/worker-thread.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/misc-intrinsics.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/platform/socket.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/preparse-data.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/preparser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/scanner.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/store-buffer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/strtod.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/type-info.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/unicode.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/utils.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/utils/random-number-generator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/v8globals.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/zone.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Hey Jochen, was something along these lines you were thinking?
6 years, 11 months ago (2014-01-28 02:51:34 UTC) #1
jochen (gone - plz use gerrit)
i think it would be preferable to have a src/base/ or something where shared headers ...
6 years, 10 months ago (2014-01-28 13:14:00 UTC) #2
tfarina
On 2014/01/28 13:14:00, jochen wrote: > i think it would be preferable to have a ...
6 years, 10 months ago (2014-01-28 16:58:39 UTC) #3
tfarina
Hey Jochen, does this (PS3) works for you?
6 years, 10 months ago (2014-01-29 01:03:22 UTC) #4
jochen (gone - plz use gerrit)
+sven I like the general idea, wdyt Sven?
6 years, 10 months ago (2014-01-29 08:59:56 UTC) #5
Sven Panne
On 2014/01/29 08:59:56, jochen wrote: > +sven > > I like the general idea, wdyt ...
6 years, 10 months ago (2014-01-30 07:40:18 UTC) #6
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-01-30 08:08:41 UTC) #7
On 2014/01/30 07:40:18, Sven Panne wrote:
> On 2014/01/29 08:59:56, jochen wrote:
> > +sven
> > 
> > I like the general idea, wdyt Sven?
> 
> Hmmm, actually I don't think it makes sense in its current form: What is the
> advantage of moving globals.h around? Even if at some point in the future we
> re-use Chrome's base/, globals.h is very v8-specific. Perhaps I am
> misunderstanding things here...
> 
> Benedikt?

I don't think the goal is to prepare for using chromium's base, at least not
anytime soon.

I want to get to a point were libplatform is a separate library which an
embedder can use (instead of providing their own implementation). Existing code
should either move to libplatform/ and v8 depends on it via the v8-platform.h
header, or, if both v8 and libplatform want to use it, to some base/ or shared/
or common/ or whatever library

Powered by Google App Engine
This is Rietveld 408576698