Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/base/globals.h

Issue 145583014: A fix for the globals.h TODO in libplatform. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: fix header include guard Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/atomicops.h ('k') | src/bignum.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #ifndef V8_GLOBALS_H_ 28 #ifndef V8_BASE_GLOBALS_H_
29 #define V8_GLOBALS_H_ 29 #define V8_BASE_GLOBALS_H_
30 30
31 #include "../include/v8stdint.h" 31 #include "../../include/v8stdint.h"
32 32
33 // Unfortunately, the INFINITY macro cannot be used with the '-pedantic' 33 // Unfortunately, the INFINITY macro cannot be used with the '-pedantic'
34 // warning flag and certain versions of GCC due to a bug: 34 // warning flag and certain versions of GCC due to a bug:
35 // http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11931 35 // http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11931
36 // For now, we use the more involved template-based version from <limits>, but 36 // For now, we use the more involved template-based version from <limits>, but
37 // only when compiling with GCC versions affected by the bug (2.96.x - 4.0.x) 37 // only when compiling with GCC versions affected by the bug (2.96.x - 4.0.x)
38 #if V8_CC_GNU && V8_GNUC_PREREQ(2, 96, 0) && !V8_GNUC_PREREQ(4, 1, 0) 38 #if V8_CC_GNU && V8_GNUC_PREREQ(2, 96, 0) && !V8_GNUC_PREREQ(4, 1, 0)
39 # include <limits> // NOLINT 39 # include <limits> // NOLINT
40 # define V8_INFINITY std::numeric_limits<double>::infinity() 40 # define V8_INFINITY std::numeric_limits<double>::infinity()
41 #elif V8_CC_MSVC 41 #elif V8_CC_MSVC
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 // there is no semantic difference between the strict and the extended mode in 412 // there is no semantic difference between the strict and the extended mode in
413 // the backend, so both modes are represented by the kStrictMode value. 413 // the backend, so both modes are represented by the kStrictMode value.
414 enum StrictModeFlag { 414 enum StrictModeFlag {
415 kNonStrictMode, 415 kNonStrictMode,
416 kStrictMode 416 kStrictMode
417 }; 417 };
418 418
419 419
420 } } // namespace v8::internal 420 } } // namespace v8::internal
421 421
422 #endif // V8_GLOBALS_H_ 422 #endif // V8_BASE_GLOBALS_H_
OLDNEW
« no previous file with comments | « src/atomicops.h ('k') | src/bignum.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698